fix: Inconsistent rendering on scrollToBottom button #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
force-pushed
the
fix/UIKIT-3972/scroll_bottom
branch
from
d5781f6
to
a8ddde6
Compare
|
|
HoonBaek
approved these changes
May 25, 2023
| @@ -17,6 +17,9 @@ import useSendbirdStateContext from '../../../../hooks/useSendbirdStateContext'; | |||
| import { UserMessage } from '@sendbird/chat/message'; | |||
| import { MessageProvider } from '../../../Message/context/MessageProvider'; | |||
| import { useHandleOnScrollCallback } from '../../../../hooks/useHandleOnScrollCallback'; | |||
| import { useSetScrollToBottom } from './hooks/useSetScrollToBottom'; | |||
|
|
|||
| const SCROLL_BOTTOM_PADDING = 200; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While refactor, we removed scrollToButton, it got coupled with
handleOnScrollwhich means, it would be called only when data fetching is involved
Seperating these logics would fix this
fixes: https://sendbird.atlassian.net/browse/UIKIT-3972