[v3.4.3] (Mar 24 2023) #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoonBaek
approved these changes
Mar 24, 2023
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@sendbird/uikit-react", | |||
| "version": "3.4.2", | |||
| "version": "3.4.3-rc.1", | |||
There was a problem hiding this comment.
need to remove rc before release
Features:
* Add rollup-plugin-size-snapshot for bundle-size
Run rollup-plugin-size-snapshot on build,
we will check bundle size before every release
* Move old samples to use vite
React team these days are using vite for their samples,
CRA is discourged
* Run code coverage on commenting `./coverage`
Check code coverage on PR comment
* Add prop to disable Channel & Thread inputs
Add prop: `disabled?: false` for Channel & Thread MessageInputWrapper
* Replace renderToString(react-dom) with custom fn
Replace renderToString from react-dom/server with custom function
This function was creating issue in customers with cra@4 & react@17
Fixes:
* Replace outdated CSS rules
`justify-content: start;` and `height: fill-available;`
* Menu position in tight screens
* Condition where some menus get clipped in left side:
* Usually user profile in channel moderation
* Context menu of last item in channel gets clipped in the bottom
sravan-s
force-pushed
the
release/v3.4.3
branch
from
e4234d1
to
8389354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
./coverageCheck code coverage on PR commentdisabled?: falsefor Channel & Thread MessageInputWrapperFixes:
justify-content: start;andheight: fill-available;https://sendbird.atlassian.net/browse/SDKRLSD-738