refactor: Add testid to the components in Channel #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HoonBaek
force-pushed
the
refactor/CLNP-2666/Add-testid-to-channel-components
branch
from
f152fac
to
c5e31c2
Compare
bang9
reviewed
May 11, 2024
bang9
reviewed
May 13, 2024
src/modules/GroupChannel/components/FileViewer/FileViewerView.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 14, 2024
src/ui/ReactionButton/__tests__/__snapshots__/ReactionButton.spec.js.snap
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 14, 2024
bang9
reviewed
May 14, 2024
bang9
reviewed
May 14, 2024
src/ui/ReactionButton/index.tsx
Outdated
| @@ -53,6 +53,7 @@ const ReactionButton = React.forwardRef((props: ReactionButtonProps, ref: Forwar | |||
| {...onClickHandler} | |||
| tabIndex={0} | |||
| data-sb-id={dataSbId} | |||
| data-testid={dataSbId} | |||
There was a problem hiding this comment.
nit: 이건 기존에 사용하고있는 dataSbId 가 좀 많아서 이해는 되는 부분인데, 아래의 관점에서 좋은 선택일지 나중에 고민해보시면 좋을것 같아서 코멘트 남깁니다.
- 작성된 testID 와 dataSbId 의 컨벤션 문제 (히스토리를 모르는 개발자가, 나중에 코드를 보았을때 추측을 하게되는 코드는 좋지 않다.
ex: 여긴 왜 다른데랑 다른형식으로 작성이 되어있지?) - 새롭게 추가되는 인터페이스에, 앞으로 제거할 레거시를 이어가는것이 좋은 선택인지 (
ex: 여러번의 메이저 버전을 넘어오는 과정에서 이러한 선택이 없었는지, 있었다면 다음 메이저 버전에서 개선을 했었는지, 개선을 했다면 어떤 방식으로 이 태스크를 챙겼는지 등.. 과거에서 되돌아 볼 수 있음)
|
Do you have a ticket for this? |
|
@HoonBaek Please resolve conflicts |
HoonBaek
force-pushed
the
refactor/CLNP-2666/Add-testid-to-channel-components
branch
from
df970c3
to
78f3551
Compare
|
I attach the ticket link and resolve the conflict, pls review it again @bang9 |
HoonBaek
force-pushed
the
refactor/CLNP-2666/Add-testid-to-channel-components
branch
from
edeaf7e
to
6731e94
Compare
bang9
reviewed
May 21, 2024
| @@ -19,14 +19,19 @@ export interface MenuItemProps { | |||
| children: ReactElement | ReactElement[] | ReactNode; | |||
| onClick?: (e: MouseEvent<HTMLLIElement>) => void; | |||
| disable?: boolean; | |||
| /** | |||
| * @deprecated Please use the testID instead | |||
| */ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLNP-2666
Added
data-testidto the UI components for making it easily to select them in the QE test