Remove onSuccess / onError in Provider

sendbird · May 26, 2023 · 5245991 · 5245991
1 parent 27596f8
commit 5245991
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 18 deletions.
diff --git a/src/lib/Sendbird.tsx b/src/lib/Sendbird.tsx
@@ -264,12 +264,6 @@ const Sendbird = ({
       }}
     >
     <UIKitConfigProvider
-      onSuccess={() => {
-        logger?.info?.('SendbirdProvider | useConnect/setupConnection/getUIKitConfiguration succeed');
-      }}
-      onError={error => {
-        logger?.error?.('SendbirdProvider | useConnect/setupConnection/getUIKitConfiguration failed', error);
-      }}
       appConfigurations={{
         common: {
           enableUsingDefaultUserProfile: !uikitConfigurations.disableUserProfile,

diff --git a/src/lib/UIKitConfigProvider/index.tsx b/src/lib/UIKitConfigProvider/index.tsx
@@ -59,13 +59,12 @@ const initialConfig = {
 };
 
 interface UIKitConfigContextInterface {
-  initDashboardConfigs: (sdk: SendbirdChat) => void;
+  initDashboardConfigs: (sdk: SendbirdChat) => Promise<void>;
   configs: UIKitConfigInfo;
 }
 const UIKitConfigContext = createContext<UIKitConfigContextInterface>({
-  /* eslint-disable @typescript-eslint/no-empty-function */
-  initDashboardConfigs: () => {},
-  configs: {} as UIKitConfigInfo,
+  initDashboardConfigs: () => Promise.resolve(),
+  configs: initialConfig,
 });
 
 interface UIKitConfigProviderProps {
@@ -74,11 +73,9 @@ interface UIKitConfigProviderProps {
   // If the storage value is not provided,
   // it'll fetch the new configs set by dashboard everytime
   storage?: any;
-  onSuccess?: () => void;
-  onError?: (error: any) => void;
 }
 
-const UIKitConfigProvider = ({ storage, children, onError, onSuccess /* appConfigurations */ }: UIKitConfigProviderProps) => {
+const UIKitConfigProvider = ({ storage, children /* appConfigurations */ }: UIKitConfigProviderProps) => {
   // TODO: Implement
   // const localConfigs = mergeConfigs(initialConfig, mapToUIKItConfig(configurations));
   const [remoteConfigs, setRemoteConfigs] = useState(initialConfig);
@@ -91,7 +88,7 @@ const UIKitConfigProvider = ({ storage, children, onError, onSuccess /* appConfi
 
       if (storage == null) {
         const payload = await sdk.getUIKitConfiguration().json;
-        setRemoteConfigs(snakeToCamel(payload.last_updated_at));
+        setRemoteConfigs(snakeToCamel(payload.uikit_configurations));
       }
 
       // TODO: Implement
@@ -103,9 +100,8 @@ const UIKitConfigProvider = ({ storage, children, onError, onSuccess /* appConfi
       //   const updatedConfigs = await manager.update(newConfigs);
       //   setRemoteConfigs(updatedConfigs);
       // }
-      onSuccess?.();
     } catch (error) {
-      onError?.(error);
+      //
     }
   }, []);
 

diff --git a/src/lib/hooks/useConnect/setupConnection.ts b/src/lib/hooks/useConnect/setupConnection.ts
@@ -98,7 +98,18 @@ export async function setUpConnection({
         sdkDispatcher({ type: INIT_SDK, payload: newSdk });
         userDispatcher({ type: INIT_USER, payload: user });
 
-        await initDashboardConfigs(newSdk);
+        initDashboardConfigs(newSdk)
+          .then(config => {
+            logger?.info?.('SendbirdProvider | useConnect/setupConnection/getUIKitConfiguration success', {
+              config,
+            });
+          })
+          .catch(error => {
+            logger?.error?.('SendbirdProvider | useConnect/setupConnection/getUIKitConfiguration failed', {
+              error,
+            });
+          });
+
         // use nickname/profileUrl if provided
         // or set userID as nickname
         if ((nickname !== user.nickname || profileUrl !== user.profileUrl)

diff --git a/src/lib/hooks/useConnect/types.ts b/src/lib/hooks/useConnect/types.ts
@@ -29,7 +29,7 @@ export type StaticTypes = {
   logger: Logger;
   sdkDispatcher: SdkDispatcher;
   userDispatcher: UserDispatcher;
-  initDashboardConfigs: (sdk: SendbirdChat) => void;
+  initDashboardConfigs: (sdk: SendbirdChat) => Promise<void>;
 };
 
 export type ConnectTypes = TriggerTypes & StaticTypes;