Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AC-2362] fix: Allow welcome messages to be displayed even when no messages in channel #221

Merged
merged 16 commits into from
May 21, 2024
Merged

[AC-2362] fix: Allow welcome messages to be displayed even when no messages in channel #221

merged 16 commits into from
May 21, 2024

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented May 17, 2024 •
edited

What changed?

Before

  • Given welcome messages are displayed only when there is at least one actual welcome message in the channel.

After

  • Given welcome messages are displayed event when no messages in the channel.

Changelog

  • Fixed a bug where injected welcome messages are not displayed when there is no message in the channel

Ticket

https://sendbird.atlassian.net/browse/AC-2362

@liamcho liamcho added the 1.5.8 label May 17, 2024
@liamcho liamcho requested review from AhyoungRyu and bang9 May 17, 2024 10:20
@liamcho liamcho self-assigned this May 17, 2024
liamcho
liamcho commented May 17, 2024
View reviewed changes
src/components/CustomChannelComponent.tsx
lastWelcomeMessageCreatedAt ?? firstMessageCreatedAt;
if (isWelcomeMessagesGiven && prevMessageTimestamp) {
hasSeparator = !isSameDay(message.createdAt, prevMessageTimestamp);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasSeparator logic is for deciding whether to add data separator or not (above message)

bang9
bang9 reviewed May 17, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@bang9 bang9 added 1.5.9 and removed 1.5.8 labels May 17, 2024
@liamcho liamcho force-pushed the feat/AC-2362-support-welcome-messages branch from 0ee639b to b6bbe5b Compare May 20, 2024 04:27
@liamcho liamcho requested a review from bang9 May 20, 2024 04:28
bang9
bang9 reviewed May 20, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@liamcho liamcho requested a review from bang9 May 20, 2024 05:18
@liamcho liamcho force-pushed the feat/AC-2362-support-welcome-messages branch 2 times, most recently from 31893db to b3ccac3 Compare May 20, 2024 08:11
@liamcho liamcho requested a review from bang9 May 20, 2024 08:20
@bang9 bang9 changed the title fix: Allow welcome messages to be displayed even when no messages in channel [AC-2362] fix: Allow welcome messages to be displayed even when no messages in channel May 20, 2024
bang9
bang9 reviewed May 20, 2024
View reviewed changes
packages/uikit Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

서브모듈 감좀 잡히시나요?ㅎㅎ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조금요 이제 알아가는중입니다 ㅎㅎ

@liamcho liamcho requested a review from bang9 May 20, 2024 11:12
@liamcho liamcho requested a review from bang9 May 21, 2024 01:45
bang9
bang9 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

liamcho and others added 16 commits May 21, 2024 12:29
@liamcho
Allow welcome messages to be displayed even when no messages in channel
0538265
@liamcho
lint
509b56b
@liamcho
put back versio
43794f1
@liamcho
minor
6d073a8
@liamcho @bang9
Update src/components/WelcomeMessages.tsx
18c7eac 
Co-authored-by: Hyungu Kang | Airen <gusrn1423@naver.com>
@liamcho @bang9
Update src/components/CustomChannelComponent.tsx
2ccc6c8 
Co-authored-by: Hyungu Kang | Airen <gusrn1423@naver.com>
@liamcho @bang9
Update src/components/CustomChannelComponent.tsx
f223acb 
Co-authored-by: Hyungu Kang | Airen <gusrn1423@naver.com>
@bang9 @liamcho
Update src/components/CustomChannelComponent.tsx
540ca3d
@liamcho
apply feeds
1c243fa
@liamcho
move file
50876cf
@liamcho
fix
2230e83
@liamcho
Update uikit head
d96abd1
@liamcho @bang9
Update src/components/messages/WelcomeMessages.tsx
aecb9c1 
Co-authored-by: Hyungu Kang | Airen <gusrn1423@naver.com>
@liamcho @bang9
Update src/components/CustomChannelComponent.tsx
93e8d3a 
Co-authored-by: Hyungu Kang | Airen <gusrn1423@naver.com>
@liamcho
apply feeds
2cd913d
@liamcho
apply feeds
e074b06
@liamcho liamcho force-pushed the feat/AC-2362-support-welcome-messages branch from a41d5ea to e074b06 Compare May 21, 2024 03:32
@liamcho liamcho merged commit 8f034a2 into develop May 21, 2024
@liamcho liamcho deleted the feat/AC-2362-support-welcome-messages branch May 21, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bang9 bang9 bang9 approved these changes

@AhyoungRyu AhyoungRyu Awaiting requested review from AhyoungRyu

Assignees

@liamcho liamcho

Labels
1.5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liamcho @bang9