Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cause to collection errors #2305

Merged
merged 3 commits into from
May 24, 2023
Merged

Add cause to collection errors #2305

merged 3 commits into from
May 24, 2023

Commits on May 24, 2023

  1. rename "lastError" to "cause" in most exceptions

    @asolntsev
    asolntsev committed May 24, 2023
    Configuration menu
    Copy the full SHA
    de129c9 View commit details
    Browse the repository at this point in the history

  2. Add cause to all collection failures 

    The case was that innocent check like `$$.shouldHave(attributes(...))` failed because Appium could not read Android-specific attribute on iOS app. But this exception was not visible in the assertion error. :(
    @asolntsev
    asolntsev committed May 24, 2023
    Configuration menu
    Copy the full SHA
    067f418 View commit details
    Browse the repository at this point in the history

  3. for Edge browser, run only a small subset of tests on GitHub Actions. 

    Edge browser is quite unstable there. It often fails because of env instability, and never - because of Edge-specific errors in Selenide.
    @asolntsev
    asolntsev committed May 24, 2023
    Configuration menu
    Copy the full SHA
    beec971 View commit details
    Browse the repository at this point in the history