-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2283 Escape special characters in subject #2284
Merged
asolntsev
merged 3 commits into
selenide:main
from
Au6ojlut:escape-special-chars-in-report
May 23, 2023
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
Report for escapeSpecialCharactersInSubject | ||
+----------------------+------------------------------------------------------+------------+------------+ | ||
| Element | Subject | Status | ms. | | ||
+----------------------+------------------------------------------------------+------------+------------+ | ||
| open | https://some.com/ | PASS | 100 | | ||
| shouldHave | text "\u0006with\n\t\f\bspecial\n\r\u00A0characters" | PASS | 100 | | ||
| #loginButton | click | FAIL | 100 | | ||
+----------------------+------------------------------------------------------+------------+------------+ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a first glance, the good moment to escape characters is not the construction of
SimpleLogEvent
, but when we renderSimpleLogEvent
. In other words, when we generate the resulting report. Then we could escape all fields, not only subject.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we need to know the max size of a cell of the report table. If the calculation was made before the
escape
was applied then the final max size may be incorrect.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
element
andsubject
are just strings, I believe, that they are the only place where special characters can appear. So, it's enough to escape them, not all the report line/row.But, I also didn't find a case when the
element
could contain some special characters (only some synthetic example), that's why I left it as is, but it can be easily fixed.