Skip to content
This repository has been archived by the owner on May 29, 2023. It is now read-only.

added wrapper methods for getContextHandles and setContext #149

Merged

Conversation

amuthansakthivel
Copy link
Contributor

Proposed changes

Solves the issue

Checklist

  • Checkstyle and unit tests are passed locally with my changes by running gradlew check command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@Test
void contexts() {
SelenideAppium.openAndroidDeepLink("mydemoapprn://webview", "com.saucelabs.mydemoapp.rn");
SelenideAppium.setContext("NATIVE_APP");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to test switching between different contexts.
Does this app has some other contexts in addition to NATIVE_APP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asolntsev - I have altered the test now to validate switching context. I have also added another method to get the current context

@asolntsev asolntsev added this to the 2.7.1 milestone Apr 3, 2023
@asolntsev asolntsev self-assigned this Apr 3, 2023
@asolntsev asolntsev linked an issue Apr 3, 2023 that may be closed by this pull request
@asolntsev asolntsev modified the milestones: 2.7.1, 2.7.2 Apr 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@asolntsev asolntsev modified the milestones: 2.8.0, 2.9.0 May 22, 2023
@asolntsev asolntsev merged commit 6a1bebd into selenide:main May 22, 2023
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants