Add appium collection condition and appium condition classes

[amuthansakthivel]

Proposed changes

Fix for selenide/selenide#2300

Checklist

• Checkstyle and unit tests are passed locally with my changes by running gradlew check command
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[amuthansakthivel]

@asolntsev @BorisOsipov - Please review

[asolntsev]

@amuthansakthivel Thank you for your contribution. Let's discuss it a bit.
What attributes do you really need to check? If you need to check texts, then probably this suggestion might be easier to use? selenide/selenide#2300

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[amuthansakthivel]

selenide/selenide#2300 (comment)

yes @asolntsev - Text is an attribute in appium and yes if we can fetch attributes dynamically that's what we need

[asolntsev]

@amuthansakthivel But do I correctly understand that we still need to get different Text attributes in iOS and Android?

[amuthansakthivel]

@amuthansakthivel But do I correctly understand that we still need to get different Text attributes in iOS and Android?

yes @asolntsev

[asolntsev]

@amuthansakthivel Same question as in #151 (comment) :

Can't we make this api more generic?

I mean, this line is hard to read:

$(mobileElement)
      .shouldHave(AppiumCondition.attributeWithValue("content-desc", "name", "expected-value"));

1. The reader doesn't know which one is for Android and which one is for iOS.
2. What happens in a 3rd mobile OS will appear next year?

Maybe some builder for attributes like this?

$(mobileElement)
      .shouldHave(AppiumCondition.attributeWithValue(MobileAttributes.android("content-desc").ios("name"), "expected-value"));

[amuthansakthivel]

@amuthansakthivel Same question as in #151 (comment) :

Can't we make this api more generic?

I mean, this line is hard to read:

$(mobileElement)
      .shouldHave(AppiumCondition.attributeWithValue("content-desc", "name", "expected-value"));

1. The reader doesn't know which one is for Android and which one is for iOS.
2. What happens in a 3rd mobile OS will appear next year?

Maybe some builder for attributes like this?

$(mobileElement)
      .shouldHave(AppiumCondition.attributeWithValue(MobileAttributes.android("content-desc").ios("name"), "expected-value"));

This looks good to me. But I need sometime to work on this @asolntsev - Little busy with personal side of things

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication