-
Notifications
You must be signed in to change notification settings - Fork 29
Added AppiumSetValueOptions to hide keyboard #119
Added AppiumSetValueOptions to hide keyboard #119
Conversation
src/test/java/integration/android/AndroidSetValueOptionsTest.java
Outdated
Show resolved
Hide resolved
@asolntsev @BorisOsipov - This PR is now ready for review. Thanks |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@amuthansakthivel The change is good technically, but I am thinking usability... $.setValue(withText("abcd").hideKeyboard()); Isn't it simpler to just write $.setValue("abcd").hideKeyboard(); The only thing we need to achieve that is make method |
$.setValue("abcd").hideKeyboard() looks very readable. But @asolntsev, when are we planning to implement that class? This SelenideAppiumElement class should also handle https://github.com/selenide/selenide-appium/issues/106 |
@amuthansakthivel Please take a look: I added method |
@asolntsev - i am closing this PR then |
Added AppiumSetValueOptions to hide keyboard if needed after setting value to textbox.
It is a painful process to hide keyboard after every setValue. Hiding keyboard is not needed always. It is needed only if the screen size is small or element is at bottom of the screen.
So we want to leave the choice to users.
$(element).setValue(withText("abcd123").hideKeyboard());
$(element).setValue(withText("abcd123"));
$(element).setValue("abcd123");
@BorisOsipov
Checklist
gradlew check
command