Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak migration doco #1804

Merged
merged 10 commits into from
Mar 13, 2025
Merged

Tweak migration doco #1804

merged 10 commits into from
Mar 13, 2025

Conversation

72636c
Copy link
Member

@72636c 72636c commented Mar 5, 2025

Sorry for 🐌 turnaround on this

Sorry for 🐌 turnaround on this
@72636c 72636c requested a review from a team as a code owner March 5, 2025 22:45
Copy link

changeset-bot bot commented Mar 5, 2025

🦋 Changeset detected

Latest commit: e632171

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samchungy
Copy link
Contributor

samchungy commented Mar 5, 2025

Do you reckon it's too complicated to mention something about why we're bumping tsconfig target/lib and that we may accidentally bump a tsconfig which may be being used by a package? Along with what target you should be using?

https://node.green/

@zbrydon
Copy link
Contributor

zbrydon commented Mar 5, 2025

Do we want to mention the requirement to have a valid skuba.type field in the projects package.json or let the error messaging handle it?

72636c added 4 commits March 7, 2025 13:03

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@AaronMoat AaronMoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm 🙌

72636c and others added 4 commits March 11, 2025 16:59
Co-authored-by: Aaron Moat <amoat@seek.com.au>
Co-authored-by: Aaron Moat <amoat@seek.com.au>
Co-authored-by: Aaron Moat <amoat@seek.com.au>
@72636c 72636c merged commit 0ef6ea9 into main Mar 13, 2025
14 checks passed
@72636c 72636c deleted the migration-doco branch March 13, 2025 09:21
@seek-oss-ci seek-oss-ci mentioned this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants