Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity logger does not handle error/skipped events in before-class methods correctly #6066

Closed
wants to merge 2 commits into from

Conversation

asika32764
Copy link
Contributor

@asika32764 asika32764 commented Dec 3, 2024

Based on PR #6064 and related to issue #5354

Re-target to 10.5 branch.

As this PR is aim to TeamCity and origin issue is reporting the JUnit format, I didn't add the Close directive to close that issue.

@asika32764 asika32764 mentioned this pull request Dec 3, 2024
@asika32764 asika32764 changed the base branch from main to 10.5 December 3, 2024 04:53
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.

Project coverage is 94.34%. Comparing base (e75fd04) to head (5bd1b90).
Report is 10 commits behind head on 10.5.

Files with missing lines Patch % Lines
src/Logging/TeamCity/TeamCityLogger.php 56.52% 10 Missing ⚠️
...TeamCity/Subscriber/TestSuiteSkippedSubscriber.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               10.5    #6066      +/-   ##
============================================
- Coverage     94.39%   94.34%   -0.06%     
- Complexity     6455     6461       +6     
============================================
  Files           679      681       +2     
  Lines         20469    20496      +27     
============================================
+ Hits          19322    19336      +14     
- Misses         1147     1160      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann sebastianbergmann added type/bug Something is broken feature/teamcity The TeamCity logger labels Dec 6, 2024
@sebastianbergmann sebastianbergmann changed the title Fix TeamCity logging to display basic start and finish message. TeamCity logger does not handle error/skipped events in before-class methods correctly Dec 6, 2024
@sebastianbergmann
Copy link
Owner

Cherry-picked into 10.5 and merged to 11.5 and main from there. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/teamcity The TeamCity logger type/bug Something is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants