Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--exclude-filter CLI option for excluding tests from execution #5629

Conversation

marac19901990
Copy link
Contributor

Hi, I hope you will consider this, i added the --exclude-filter with everything that goes with it.
I even made the reverse logic for data provider selection, I think it doesnt make sense to have it but I leave it for you to decide.

Please give me any suggestions if you have them, and I'm willing to help with other stuff if you need me.
Thanks.

  --filter <pattern>               Filter which tests to run
  --exclude-filter <pattern>       Exclude tests for the specified filter pattern
  --test-suffix <suffixes>         Only search for test in files with specified suffix(es). Default: Test.php,.phpt

@sebastianbergmann sebastianbergmann added type/enhancement A new idea that should be implemented feature/test-runner CLI test runner labels Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fe34ee7) 89.02% compared to head (478193b) 89.07%.

Files Patch % Lines
src/Runner/Filter/NameFilterIterator.php 85.71% 1 Missing ⚠️
src/TextUI/Configuration/Cli/Configuration.php 87.50% 1 Missing ⚠️
src/TextUI/Configuration/Configuration.php 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5629      +/-   ##
============================================
+ Coverage     89.02%   89.07%   +0.05%     
- Complexity     6393     6405      +12     
============================================
  Files           682      684       +2     
  Lines         20312    20353      +41     
============================================
+ Hits          18083    18130      +47     
+ Misses         2229     2223       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marac19901990
Copy link
Contributor Author

@marac19901990 marac19901990 changed the title add exclude-filter option add exclude-filter option #5467 Dec 31, 2023
@marac19901990 marac19901990 changed the title add exclude-filter option #5467 add exclude-filter option Dec 31, 2023
@marac19901990
Copy link
Contributor Author

Pull request for: #5467

@sebastianbergmann sebastianbergmann changed the title add exclude-filter option --exclude-filter CLI option for excluding tests from execution Jan 1, 2024
@sebastianbergmann sebastianbergmann merged commit 478193b into sebastianbergmann:main Jan 1, 2024
25 checks passed
@marac19901990 marac19901990 deleted the main-exclude-filter-added branch January 2, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/test-runner CLI test runner type/enhancement A new idea that should be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants