Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable named data sets with the #[TestWith*] attributes #4964

Closed

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Apr 26, 2022

Adds an optional data set name argument to the #[TestWith] & #[TestWithJson] attributes:

#[TestWith(['a', 'b'], 'Name1')]
#[TestWith(['c', 'd'], 'Name2')]
public function testFoo(string $one, string $two)
{}

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48dd8a7) 89.40% compared to head (1779737) 89.41%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4964      +/-   ##
============================================
+ Coverage     89.40%   89.41%   +0.01%     
- Complexity     6425     6430       +5     
============================================
  Files           683      683              
  Lines         20405    20427      +22     
============================================
+ Hits          18243    18265      +22     
  Misses         2162     2162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HypeMC HypeMC force-pushed the named-testwith-datasets branch 2 times, most recently from 85bf9e0 to efdf917 Compare September 27, 2022 11:33
@HypeMC
Copy link
Contributor Author

HypeMC commented Jan 4, 2023

@sebastianbergmann Hi, any thoughts on this one? Judging by the few likes I got, there seems to be at least some interest in this feature. If there's anything else I can do here, please let me know.

@sebastianbergmann sebastianbergmann changed the title Enable named data sets with the #[TestWith*] attributes Enable named data sets with the #[TestWith*] attributes Jan 13, 2024
@sebastianbergmann sebastianbergmann added feature/data-provider Data Providers feature/metadata/attributes type/enhancement A new idea that should be implemented labels Jan 13, 2024
@sebastianbergmann
Copy link
Owner

Merged manually, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/data-provider Data Providers feature/metadata/attributes type/enhancement A new idea that should be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants