Closes #5288

sebastianbergmann · Mar 21, 2023 · 6c5fb82 · 6c5fb82
1 parent bbbb3b0
commit 6c5fb82
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/ChangeLog-10.0.md b/ChangeLog-10.0.md
@@ -7,6 +7,7 @@ All notable changes of the PHPUnit 10.0 release series are documented in this fi
 ### Fixed
 
 * [#5287](https://github.com/sebastianbergmann/phpunit/issues/5287): Tests from test class with same non-fully qualified class name as another test class are sometimes not discovered
+* [#5288](https://github.com/sebastianbergmann/phpunit/issues/5288): `@dataProvider` annotation rejects previously valid method name style
 
 ## [10.0.17] - 2023-03-20
 

diff --git a/src/Metadata/Parser/AnnotationParser.php b/src/Metadata/Parser/AnnotationParser.php
@@ -15,6 +15,7 @@
 use function method_exists;
 use function preg_replace;
 use function str_contains;
+use function str_replace;
 use function str_starts_with;
 use function strlen;
 use function substr;
@@ -217,6 +218,14 @@ public function forMethod(string $className, string $methodName): MetadataCollec
 
                 case 'dataProvider':
                     foreach ($values as $value) {
+                        $value = trim(
+                            str_replace(
+                                ['(', ')'],
+                                '',
+                                $value
+                            )
+                        );
+
                         if (str_contains($value, '::')) {
                             $result[] = Metadata::dataProvider(...explode('::', $value));