Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: A few simple cleanups/lints #1849

Merged
merged 1 commit into from
May 24, 2023
Merged

Commits on May 22, 2023

  1. chore: A few simple cleanups/lints

    I asked clippy to help out, to see if any simple improvements are available. I ignored most of the pedantic ones, but a few of them seemed reasonable.
    
    * in a few places, the match with `_` is used, even though there is only one other option. I think it is better to explicitly list them all - so that if another enum value is added in the future, it won't compile until someone looks at each case and decides what should the proper value be. This way there won't be any surprising breakages due to changes in the enums.
    * a few `use wildcard` inlinings
    * some big numbers are easier to read with underscores
    * `for` iterating without `.iter()`
    nyurik committed May 22, 2023
    Configuration menu
    Copy the full SHA
    f2c11a1 View commit details
    Browse the repository at this point in the history