Add Certificate::from_rustls()
#1844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's currently by-design that we don't expose publicly either native-tls or rustls types in the API, so we can upgrade to new versions internally without that being "breaking changes". |
|
Right, I didn't consider this, I guess I could replicate the interface of |
|
CI fails because some MSRV issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new method to
Certificate:from_rustls(). This allows addingOwnedTrustAnchordirectly, for example fromwebpki-roots.Certificates added through this method will be ignored on
native-tlsclients.Fixes #1843.