Fix for fetching blob URLs in Rust WebAssembly using reqwest #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Apr 10, 2023
| @@ -21,6 +21,14 @@ pub trait IntoUrlSealed { | |||
|
|
|||
| impl IntoUrlSealed for Url { | |||
| fn into_url(self) -> crate::Result<Url> { | |||
| #[cfg(target_arch = "wasm32")] | |||
There was a problem hiding this comment.
Just so I understand this, the issue was that the next check, has_host(), was false, and so the scheme was considered bad? If that's so, it'd be good to include a code comment here explaining that, so we remember why this check is here :)
There was a problem hiding this comment.
You're right, I just added an explanation.
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
May 1, 2023
Bumps reqwest from 0.11.16 to 0.11.17. Release notes Sourced from reqwest's releases. v0.11.17 What's Changed Upgrade internal dependencies of Experimental HTTP/3 to use quinn v0.9 (wasm) Fix blob url support New Contributors @skyf0l made their first contribution in seanmonstar/reqwest#1797 Changelog Sourced from reqwest's changelog. v0.11.17 Upgrade internal dependencies of Experimental HTTP/3 to use quinn v0.9 (wasm) Fix blob url support Commits eeca649 v0.11.17 b4d5ab0 update h3 and h3-quinn to 0.0.2 (#1811) 2fa69ad wasm: blob url support (#1797) See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue when trying to fetch a blob URL in Rust WebAssembly using reqwest. The error message stated that the URL scheme was not allowed. It was due to the parsing of the URL, so I fixed it.
Fix #1796
Thank you for considering this pull request!