Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasm): support request timeout #1760

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(wasm): support request timeout #1760

wants to merge 1 commit into from

Conversation

flisky
Copy link

@flisky flisky commented Feb 24, 2023

Thanks for PR #1755, making wasm timeout support is super easy now.

fixes #1135 supersede #1274

seanmonstar
seanmonstar reviewed Feb 24, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@flisky
Copy link
Author

flisky commented May 17, 2023

I've replace gloo-timers with wasm-bindgen functions.

(For the potential question: why not use web_sys::Window::set_timout_*? Because Window doesn't work in nodejs & webworker. However, I can switch into predefined functions if Window is only target.)

@flisky flisky mentioned this pull request Sep 6, 2023
Closed
@sosaucily sosaucily mentioned this pull request Sep 11, 2023
Open
@aorticweb
Copy link

is there a plan to merge this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar left review comments

@dmeijboom dmeijboom dmeijboom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequestBuilder doesn't have a timeout in wasm module
4 participants
@flisky @aorticweb @seanmonstar @dmeijboom