Reuse RuboCop::CLI
#198
Merged
Reuse RuboCop::CLI
#198
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RuboCop::CLI` is generated only once using memoization, instead of creating a new instance for each file. This eliminates redundant processes related to `RuboCop::CLI`, improving performance. Fixes sds#193.
|
I can confirm that it works fine now. Thank you @koic! |
|
Thank you. Released in 0.32.2 |
|
Wow, this is a great standalone improvement as well. Even without the new plugin system our time to lint went from 30s to 13s, so 2x. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuboCop::CLIis generated only once usinginitialize, instead of creating a new instance for each file. This eliminates redundant processes related toRuboCop::CLI, improving performance.Fixes #193.