Skip to content

Commit

Permalink
Add support for @async Kotlin function returning Unit?
Browse files Browse the repository at this point in the history
  • Loading branch information
sdeleuze committed Dec 22, 2023
1 parent 9f2970b commit c045bc4
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
* @author Juergen Hoeller
* @author Stephane Nicoll
* @author He Bo
* @author Sebastien Deleuze
* @since 3.1.2
*/
public abstract class AsyncExecutionAspectSupport implements BeanFactoryAware {
Expand Down Expand Up @@ -292,7 +293,7 @@ else if (org.springframework.util.concurrent.ListenableFuture.class.isAssignable
else if (Future.class.isAssignableFrom(returnType)) {
return executor.submit(task);
}
else if (void.class == returnType) {
else if (void.class == returnType || "kotlin.Unit".equals(returnType.getName())) {
executor.submit(task);
return null;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/*
* Copyright 2002-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.scheduling.annotation

import org.aopalliance.intercept.MethodInvocation
import org.assertj.core.api.Assertions
import org.junit.jupiter.api.Test
import org.mockito.BDDMockito.given
import org.mockito.Mockito

/**
* Kotlin tests for [AnnotationAsyncExecutionInterceptor].
*
* @author Sebastien Deleuze
*/
class AnnotationAsyncExecutionInterceptorKotlinTests {

@Test
fun nullableUnitReturnValue() {
val interceptor = AnnotationAsyncExecutionInterceptor(null)

class C { @Async fun nullableUnit(): Unit? = null }
val invocation = Mockito.mock<MethodInvocation>()
given(invocation.method).willReturn(C::class.java.getDeclaredMethod("nullableUnit"))

Assertions.assertThat(interceptor.invoke(invocation)).isNull()
}

}

0 comments on commit c045bc4

Please sign in to comment.