Skip to content

Pull upstream changes until 4.18.1 #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Mar 5, 2025

Conversation

Bouncheck
Copy link
Collaborator

No description provided.

michaelsembwever and others added 28 commits December 7, 2023 23:36
 ASF does not have a subscription for fossa

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…tion tests)

 patch by Mick Semb Wever; reviewed by Wei Deng for CASSANDRA-18970
…ull in config, rather than using sentinel Duration.ZERO
…nsport_port_ssl for DSE 6.8 (4.x edition)

patch by absurdfarce; reviewed by absurdfarce and adutra for CASSANDRA-19352
The java driver uses netty channel attributes to decorate a
connection's channel with the cluster name (returned from
the system.local table) and the map from the OPTIONS response, both
of which are obtained on connection initialization.

There's an issue here that I wouldn't expect to see in practice in
that the AttributeKey's used are created using
AttributeKey.newInstance, which throws an exception if an
AttributeKey of that name is defined anywhere else in evaluated code.

This change attempts to resolve this issue by changing AttributeKey
initialiation in DriverChannel from newInstance to valueOf, which avoids
throwing an exception if an AttributeKey of the same name was previously
instantiated.

patch by Andy Tolbert; reviewed by Bret McGuire, Alexandre Dutra, Abe Ratnofsky for CASSANDRA-19290
patch by Ekaterina Dimitrova; reviewed by Alexandre Dutra and Bret McGuire for CASSANDRA-19333
…sfile

patch by Bret McGuire; reviewed by Bret McGuire for CASSANDRA-19504
Typo carried over from old docs, needed closing parenthesis.
…opulating the component field.

Patch by Bret McGuire; reviewed by Bret McGuire, Alexandre Dutra
If an exception was thrown while getting new metadata as
part of schema refresh it died on the admin executor instead
of being propagated to the CompletableFuture argument.
Instead, catch those exceptions and hand them off to the
CompletableFuture.

patch by Ammar Khaku; reviewed by Chris Lohfink, Bret McGuire for CASSANDRA-19468
Patch by Bret McGuire; reviewed by Bret McGuire, Alexandre Dutra for PR 1914
patch by Bret McGuire; reviewed by Bret McGuire for PR 1928
patch by Bret McGuire; reviewed by Bret McGuire for PR 1930
patch by Bret McGuire; reviewed by Bret McGuire, Alexandre Dutra for CASSANDRA-19292
…onfiguration for graceful automatic failovers

patch by Nitin Chhabra; reviewed by Alexandre Dutra, Andy Tolbert, and Bret McGuire for JAVA-3142
patch by Jane He and Bret McGuire; reviewed by Bret McGuire for CASSANDRA-19568
patch by Nitin Chhabra; reviewed by Bret McGuire for JAVA-3142
…thub.com/apache/cassandra-java-driver into scylla-4.x-merge-4.18.1

Following conflict resolutions and additional changes were made:
- Version was changed to 4.18.1.0-SNAPSHOT
- deep-lic-scan.yaml was removed. Likewise we don't have a fossa subscription.
- added with modifications previously skipped distribution-source module.
  Changed groupId, versions and names.
- added with modifications previously skipped distribution-tests module.
  Changed groupId, versions and names.
- Skipped license-maven-plugin which was checking for ASF license headers.
- removed `<oldArtifacts>` section of revapi plugin configuration pointing to
  datastax.
- Skipped addition of maven-remote-resources-plugin (pom.xml).
- Skipped removal of distributionManagement section (pom.xml). We are not using
  `org.apache` parent pom to define that part.
- Switched Scylla specific uses of `AttributeKey.newInstance` to `.valueOf` too
- Added `WHERE key='local'` to `system.local` queries in `DefaultTopologyMonitorTest`
- Removed irrelevant to Scylla version of the driver parts of the documentation
- Merged in translation between older and newer variations of config keys
  and values.
- Discarded some adjustments for upstream's Jenkins setup which conflicted
  with adjustments for our CI.
- Added extra stubs in BasicLoadBalancingPolicyPreferredRemoteDcsTest
  to match Scylla's modifications.
@Bouncheck Bouncheck self-assigned this Mar 5, 2025
@Bouncheck
Copy link
Collaborator Author

Identical to #440, which was accidentally merged with wrong mode.

@Bouncheck Bouncheck merged commit 815bfcd into scylladb:scylla-4.x Mar 5, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants