Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TunableMixin and TuneAnalysis #1831

Merged
merged 49 commits into from
Jan 20, 2023
Merged

Add TunableMixin and TuneAnalysis #1831

merged 49 commits into from
Jan 20, 2023

Conversation

martinkim0
Copy link
Contributor

@martinkim0 martinkim0 commented Jan 4, 2023

Closes #1799

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 90.62% // Head: 90.39% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (06a0b07) compared to base (8c30806).
Patch coverage: 78.98% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1831      +/-   ##
==========================================
- Coverage   90.62%   90.39%   -0.23%     
==========================================
  Files         139      141       +2     
  Lines       10965    11103     +138     
==========================================
+ Hits         9937    10037     +100     
- Misses       1028     1066      +38     
Impacted Files Coverage Δ
scvi/autotune/_callbacks.py 0.00% <0.00%> (ø)
scvi/autotune/_defaults.py 100.00% <ø> (ø)
scvi/utils/_exceptions.py 36.36% <36.36%> (ø)
scvi/autotune/_manager.py 80.90% <81.41%> (+2.92%) ⬆️
scvi/autotune/__init__.py 100.00% <100.00%> (ø)
scvi/autotune/_tuner.py 100.00% <100.00%> (ø)
scvi/autotune/_types.py 100.00% <100.00%> (ø)
scvi/model/_amortizedlda.py 96.92% <100.00%> (+0.04%) ⬆️
scvi/model/_autozi.py 98.79% <100.00%> (+0.01%) ⬆️
scvi/model/_condscvi.py 96.66% <100.00%> (+0.03%) ⬆️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

scvi/train/_trainer.py Outdated Show resolved Hide resolved
@martinkim0
Copy link
Contributor Author

@adamgayoso Any idea what could be happening with docs fail? Haven't been able to figure it out

@adamgayoso
Copy link
Member

Seems related to tox-dev/sphinx-autodoc-typehints#302

@martinkim0
Copy link
Contributor Author

Looks like all new docs builds are failing with the same error

.gitignore Outdated Show resolved Hide resolved
@martinkim0 martinkim0 changed the title Implement _tunables for base classes Add TunableMixin and TuneAnalysis Jan 20, 2023
@martinkim0 martinkim0 enabled auto-merge (squash) January 20, 2023 03:27
@martinkim0 martinkim0 merged commit 50bdfba into main Jan 20, 2023
@martinkim0 martinkim0 deleted the tunables-1799 branch January 20, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define _tunables class property at the base level
2 participants