-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pytest 8 compat #2838
Fix pytest 8 compat #2838
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2838 +/- ##
==========================================
+ Coverage 72.85% 73.67% +0.82%
==========================================
Files 111 111
Lines 12383 12386 +3
==========================================
+ Hits 9022 9126 +104
+ Misses 3361 3260 -101
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Changes:
matplotlib.testing:setup
should be called before each (plotting) testsc.set_figure_params(dpi=40, color_map="viridis")
seems to be overwritten. When calling it inline, it messes up the figure paramssc.pl.set_rcParams_defaults()
is redundant,setup
from above does that.