Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test compatibility with Pytest 8 #1298

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Fix test compatibility with Pytest 8 #1298

merged 3 commits into from
Jan 12, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Jan 12, 2024

  • Closes N/A
  • Tests added
  • Release note added (or unnecessary)

See pytest-dev/pytest#11759

TODO:

  • make sure the PreRelease test run actually uses Pytest 8

@flying-sheep flying-sheep added this to the 0.11.0 milestone Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a1caa9) 85.28% compared to head (b8a80e6) 83.13%.

❗ Current head b8a80e6 differs from pull request most recent head 82e54d3. Consider uploading reports for the commit 82e54d3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1298      +/-   ##
==========================================
- Coverage   85.28%   83.13%   -2.15%     
==========================================
  Files          34       34              
  Lines        5490     5490              
==========================================
- Hits         4682     4564     -118     
- Misses        808      926     +118     
Flag Coverage Δ
gpu-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@flying-sheep flying-sheep enabled auto-merge (squash) January 12, 2024 11:49
@flying-sheep flying-sheep merged commit 6beecde into main Jan 12, 2024
12 checks passed
@flying-sheep flying-sheep deleted the pytest-8 branch January 12, 2024 11:57
@flying-sheep flying-sheep modified the milestones: 0.11.0, 0.10.5 Jan 23, 2024
@flying-sheep
Copy link
Member Author

@meeseeksdev backport to 0.10.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant