[feat] remove stack #1044
Closed
[feat] remove stack #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightsing
force-pushed
the
feat/remove-stack
branch
from
6a3e935
to
7cce89e
Compare
# Conflicts: # bus-mapping/src/circuit_input_builder/tracer_tests.rs # geth-utils/l2geth/go.mod # geth-utils/l2geth/go.sum # go.work.sum # zkevm-circuits/src/evm_circuit/execution/error_invalid_opcode.rs
# Conflicts: # bus-mapping/Cargo.toml # bus-mapping/src/circuit_input_builder.rs # bus-mapping/src/circuit_input_builder/access.rs # bus-mapping/src/circuit_input_builder/input_state_ref.rs # bus-mapping/src/circuit_input_builder/tracer_tests.rs # bus-mapping/src/circuit_input_builder/transaction.rs # bus-mapping/src/evm/opcodes.rs # bus-mapping/src/evm/opcodes/callop.rs # bus-mapping/src/evm/opcodes/create.rs # bus-mapping/src/evm/opcodes/environment.rs # bus-mapping/src/evm/opcodes/error_oog_precompile.rs # bus-mapping/src/evm/opcodes/precompiles/mod.rs # bus-mapping/src/evm/opcodes/stackonlyop.rs # bus-mapping/src/mock.rs # bus-mapping/src/rpc.rs # bus-mapping/src/util.rs # eth-types/src/l2_types.rs # eth-types/src/lib.rs # external-tracer/src/lib.rs # geth-utils/l1geth/go.sum # geth-utils/l2geth/go.mod # geth-utils/l2geth/go.sum # geth-utils/l2geth/trace.go # integration-tests/tests/circuit_input_builder.rs # testool/Cargo.toml # testool/src/statetest/executor.rs # testool/src/utils.rs # zkevm-circuits/Cargo.toml # zkevm-circuits/src/evm_circuit/execution/addmod.rs # zkevm-circuits/src/evm_circuit/execution/callop.rs # zkevm-circuits/src/evm_circuit/execution/mulmod.rs
|
Time to fix conflicts |
…ruct # Conflicts: # bus-mapping/src/circuit_input_builder/tracer_tests.rs # bus-mapping/src/circuit_input_builder/transaction.rs # bus-mapping/src/evm/opcodes/callop.rs # bus-mapping/src/evm/opcodes/create.rs # bus-mapping/src/mock.rs # bus-mapping/src/rpc.rs # eth-types/src/lib.rs
# Conflicts: # bus-mapping/src/circuit_input_builder.rs # bus-mapping/src/circuit_input_builder/input_state_ref.rs # bus-mapping/src/circuit_input_builder/l2.rs # bus-mapping/src/evm/opcodes.rs # bus-mapping/src/evm/opcodes/address.rs # bus-mapping/src/evm/opcodes/arithmetic.rs # bus-mapping/src/evm/opcodes/balance.rs # bus-mapping/src/evm/opcodes/blockhash.rs # bus-mapping/src/evm/opcodes/calldatasize.rs # bus-mapping/src/evm/opcodes/callop.rs # bus-mapping/src/evm/opcodes/environment.rs # bus-mapping/src/evm/opcodes/error_oog_precompile.rs # bus-mapping/src/evm/opcodes/precompiles/mod.rs # bus-mapping/src/evm/opcodes/stackonlyop.rs # zkevm-circuits/src/evm_circuit/execution/addmod.rs # zkevm-circuits/src/evm_circuit/execution/callop.rs # zkevm-circuits/src/evm_circuit/execution/mulmod.rs
github-actions
bot
added
crate-mock
and removed
crate-integration-tests
crate-prover
CI
crate-geth-utils
labels
# Conflicts: # bus-mapping/src/circuit_input_builder/input_state_ref.rs # bus-mapping/src/circuit_input_builder/l2.rs # bus-mapping/src/evm/opcodes/address.rs # bus-mapping/src/evm/opcodes/error_invalid_creation_code.rs # eth-types/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr belongs to task: Remove heap allocation from GethExecStep/ExecStep
This pr is current a placeholder since it's blocked by #1043