(feat) implement EIP-1153 - transient storage #701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements TSTORE and TLOAD as specified by the following EIP: https://eips.ethereum.org/EIPS/eip-1153 https://ethereum-magicians.org/t/eip-1153-transient-storage-opcodes/553 Co-authored-by: Sara Reynolds <snreynolds2506@gmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Gary Rong <garyrong0905@gmail.com>
|
This PR looks good, but personally I will prefer breaking 34a13ff into
|
This reverts commit 34a13ff.
Thegaram
requested changes
Apr 24, 2024
Thegaram
reviewed
Apr 25, 2024
| // - Add coinbase to access list (EIP-3651) | ||
| // - Reset transient storage (EIP-1153) | ||
| func (s *StateDB) Prepare(rules params.Rules, sender, coinbase common.Address, dst *common.Address, precompiles []common.Address, list types.AccessList) { | ||
| if rules.IsBerlin { |
There was a problem hiding this comment.
This part is not the same as in upstream: https://github.com/ethereum/go-ethereum/blob/master/core/state/statedb.go#L1277
|
|
||
| // Set sets the transient-storage `value` for `key` at the given `addr`. | ||
| func (t transientStorage) Set(addr common.Address, key, value common.Hash) { | ||
| if _, ok := t[addr]; !ok { |
There was a problem hiding this comment.
| @@ -54,6 +54,8 @@ type StateDB interface { | |||
| GetProof(addr common.Address) ([][]byte, error) | |||
| GetProofByHash(addrHash common.Hash) ([][]byte, error) | |||
| GetStorageProof(a common.Address, key common.Hash) ([][]byte, error) | |||
| GetTransientState(addr common.Address, key common.Hash) common.Hash | |||
There was a problem hiding this comment.
Suggested change
| GetTransientState(addr common.Address, key common.Hash) common.Hash | |
| GetTransientState(addr common.Address, key common.Hash) common.Hash |
|
closing in favour of #721 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
https://eips.ethereum.org/EIPS/eip-1153
https://github.com/ethereum/execution-specs/blob/master/network-upgrades/mainnet-upgrades/cancun.md
https://www.notion.so/scrollzkp/Add-tload-tstore-opcodes-to-l2geth-8a54dbbcdb894ebd8e6d9c4d46b6de9a?pvs=4
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?