MAINT: sparse: fix init func sig to allow maxprint to be set #20719
+39
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scipy.sparse
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arg
maxprintin_spbase.__init__()doesn't appear in subclasses so setting maxprint during construction is not possible. See #20490This PR adds tests of setting maxprint, and tests that the new
__str__format works with maxprint set. Fixes__init__function signatures to work with maxprint being set.I set up
maxprintto be a keyword-only parameter so it doesn't disrupt the positional parameters for subclasses (in e.g. BSR where number of position-keyword parameters is one more than the other subclasses).