Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: optimize.HessianUpdateStrategy: add __matmul__ #20713

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dschmitz89
Copy link
Contributor

@dschmitz89 dschmitz89 commented May 14, 2024

Reference issue

This came up in #8792 (comment)

What does this implement/fix?

Allows to use the matmul operator @ for HessianUpdateStrategy.

Additional information

This is still missing a strict test that @ = .dot .

CC @jeffrey-hokanson : any help reviewing would be much appreciated :)

@dschmitz89 dschmitz89 requested a review from andyfaff as a code owner May 14, 2024 20:40
@github-actions github-actions bot added scipy.optimize enhancement A new feature or improvement labels May 14, 2024
@lucascolley lucascolley changed the title ENH: add __matmul__ for HessianUpdateStrategy ENH: optimize.HessianUpdateStrategy: add __matmul__ for Hes May 17, 2024
@lucascolley lucascolley changed the title ENH: optimize.HessianUpdateStrategy: add __matmul__ for Hes ENH: optimize.HessianUpdateStrategy: add __matmul__ May 17, 2024
@dschmitz89
Copy link
Contributor Author

This is ready from my side. Last thing left: I am not sure how to document that __matmul__ is implemened or if we want to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or improvement scipy.optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant