BUG: fix powm1 overflow handling #17872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-bowhay
added
defect
|
Thanks @mborland. Error handling looks good and CI is green so I'll go ahead and merge |
mckib2
approved these changes
Jan 29, 2023
tylerjereddy
added
the
backport-candidate
|
This is labeled as a bug, so I've tentatively added a backport label for |
2 tasks
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
No open issue. Supersedes #17855.
What does this implement/fix?
Implements complete error handling as defined in cmath https://en.cppreference.com/w/cpp/numeric/math/pow
Additional information
@WarrenWeckesser the C++ version of your test set with this change applied for validation can be found on this pull: boostorg/math#931. Sorry for the previous braindead PR.