BUG: Fix powm1 test case #17870
Closed
BUG: Fix powm1 test case #17870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why should the result be |
|
I think I may have merged #17855 too quickly. When the input |
|
I realize looking at that it needs the whole control flow from: https://en.cppreference.com/w/cpp/numeric/math/pow |
|
I think this is easiest if I fork Nicholas' PR which has all of the Boost changes in it already to validate the correct behaviors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
No open issue. Related PRs are #17855 and #17432.
What does this implement/fix?
Fix test case that now fails because of changes made in #17855.
-INF**2 - 1should be-INFnot+INFAdditional information
Failure can be found here.