Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Adjust Pull-Request labeler configuration #17116

Merged
merged 7 commits into from May 27, 2023

Conversation

jjerphan
Copy link
Contributor

Reference issue

Follow-up of #16870

What does this implement/fix?

This adapts the labeler configuration to resolve issues exposed in #16870 (comment).

Additional information

This is still WIP.

cc @tupui

Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjerphan for following up on this 😃

.github/workflows/pull-request-labeler.yml Outdated Show resolved Hide resolved
@j-bowhay j-bowhay added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Nov 16, 2022
@jjerphan
Copy link
Contributor Author

I am coming back to this PR after an eternity: I plan to maintain the changes of
actions/labeler#113 on my fork in the meantime. I still need to assert whether it works or not. If it does, would depending on this fork work for you or would you prefer depending on actions/labeler solely?

@tupui
Copy link
Member

tupui commented Dec 6, 2022

@jjerphan sorry for the delay, I was away.

If the fix in the reported issue works with the original repo, that would be better. We would prefer not to depend on custom actions (extra work to maintain) unless they are used by other large projects.

@jjerphan
Copy link
Contributor Author

jjerphan commented Dec 6, 2022

@jjerphan sorry for the delay, I was away.

It's fine. Congrats for getting a CZI grant to pursue your work on Scipy! 🥳

If the fix in the reported issue works with the original repo, that would be better. We would prefer not to depend on custom actions (extra work to maintain) unless they are used by other large projects.

So do I, in this case this PR is blocked.

What should we do? Should we wait for actions/labeler#113 to be integrated or should revert changes of #16870 in the meantime?

@tupui
Copy link
Member

tupui commented Dec 6, 2022

Thanks!

@jjerphan
Copy link
Contributor Author

Hi @tupui, I am coming back to you after another eternity.

actions/labeler#480 which pursues actions/labeler#113 is on the verge to be approved. I think the best is that we wait for it to be merged before taking further decisions.

@tupui
Copy link
Member

tupui commented Jan 30, 2023

Thanks! Let's do that. Seems like a new team is taking this over, great news.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seen this in-person. In it goes, thanks Julien 😃

@tupui tupui marked this pull request as ready for review May 27, 2023 00:34
@jjerphan
Copy link
Contributor Author

@tupui tupui merged commit 6047c8c into scipy:main May 27, 2023
15 of 19 checks passed
@jjerphan jjerphan deleted the maint/update-pr-labeler branch May 27, 2023 00:34
@tupui tupui added this to the 1.11.0 milestone May 27, 2023
@jjerphan
Copy link
Contributor Author

jjerphan commented Jun 8, 2023

Hi @j-bowhay,

I have seen that you have been triaging issues and PRs lately.

I am interested to know what you think of the setup this CI brought to see if this can be refined.

@j-bowhay
Copy link
Member

j-bowhay commented Jun 8, 2023

I think it is working well. One possible point for further improvement would be to pick off the acronym (eg. MAINT) and map this to a label as at the moment this still has to be done manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants