New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Adjust Pull-Request labeler configuration #17116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jjerphan for following up on this 😃
As a temporary support util actions/labeler#113 is merged.
I am coming back to this PR after an eternity: I plan to maintain the changes of |
@jjerphan sorry for the delay, I was away. If the fix in the reported issue works with the original repo, that would be better. We would prefer not to depend on custom actions (extra work to maintain) unless they are used by other large projects. |
It's fine. Congrats for getting a CZI grant to pursue your work on Scipy! 🥳
So do I, in this case this PR is blocked. What should we do? Should we wait for actions/labeler#113 to be integrated or should revert changes of #16870 in the meantime? |
Thanks! |
Hi @tupui, I am coming back to you after another eternity. actions/labeler#480 which pursues actions/labeler#113 is on the verge to be approved. I think the best is that we wait for it to be merged before taking further decisions. |
Thanks! Let's do that. Seems like a new team is taking this over, great news. |
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seen this in-person. In it goes, thanks Julien 😃
See those PRs to check behavior with the setup on my fork: |
Hi @j-bowhay, I have seen that you have been triaging issues and PRs lately. I am interested to know what you think of the setup this CI brought to see if this can be refined. |
I think it is working well. One possible point for further improvement would be to pick off the acronym (eg. MAINT) and map this to a label as at the moment this still has to be done manually. |
Reference issue
Follow-up of #16870
What does this implement/fix?
This adapts the labeler configuration to resolve issues exposed in #16870 (comment).
Additional information
This is still WIP.
cc @tupui