Fix for #6931: isotonic y_min/y_max bounds #6928
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted on #6921, the
isotonic_regression
method:y_min
/y_max
outcome (that does not work w.p.1)This PR fixes both issues by:
pre_sorted
bool parameter toisotonic_regression
with defaultTrue
, which should allow for no change in performance for the primary class callersC
reweighting approach with a data censoring pass s.t. all input values are within[y_min, y_max
].That said, as mentioned on the mailing list, I think we are still mixing use cases for the isotonic methods, and would recommend that we investigate docking and documenting against the R
isotone
package behavior:#4185 (comment)