Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Unpin pytest and regenerate lock-files #28318

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jan 31, 2024

This is mostly a behaviour changes from https://docs.pytest.org/en/stable/changelog.html#other-breaking-changes

#9288: warns() now re-emits unmatched warnings when the context closes – previously it would consume all warnings, hiding those that were not matched by the function.

I think this behaviour change makes sense and adapting our tests is easy and not controversial.

and a work-around for a pytest bug: pytest-dev/pytest#11872

It seems like pytest --pyargs sklearn in pytest 8 does not discover tests with Meson editable install for some weird reason, it could be because of collection changes in Pytest 8 maybe https://docs.pytest.org/en/stable/changelog.html#collection-changes? It seems like a meson-python issue actually, I have opened mesonbuild/meson-python#568. I think pytest --pyargs is actually broken in editable installs and is somehow working by chance with pytest<8

Copy link

github-actions bot commented Jan 31, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: fa49ce1. Link to the linter CI: here

@lesteve
Copy link
Member Author

lesteve commented Jan 31, 2024

So the CI is green but codecov fails to upload see build log. One example where having disallowed "Bypass required checks" is a minor downside. I have retriggered the failing build and it passes.

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre merged commit d61b65e into scikit-learn:main Jan 31, 2024
33 checks passed
@lesteve lesteve deleted the pytest-8 branch January 31, 2024 17:15
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants