Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Update Pyodide to 0.24.1 for JupyterLite button #27474

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Sep 26, 2023

Pyodide 0.24.1 was released September 26. Amongst other things, it has scikit-learn 1.3.1.

We may want to backport this one on top of #27405 for 1.3.1.

I tested this locally and the JupyterLite button works fine.

@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 3826ab2. Link to the linter CI: here

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then.

@thomasjpfan thomasjpfan added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Sep 27, 2023
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 32f8bda into scikit-learn:main Sep 27, 2023
33 checks passed
@thomasjpfan
Copy link
Member

@lesteve Can you open the PR to backport?

@lesteve
Copy link
Member Author

lesteve commented Sep 28, 2023

I opened #27489 for the backport to 1.3.X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants