Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.2.2 #25777

Merged
merged 68 commits into from Mar 8, 2023
Merged

Release 1.2.2 #25777

merged 68 commits into from Mar 8, 2023

Conversation

jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented Mar 7, 2023 •
edited

picks and drops

pick cc8228e FIX TransformerMixin does not override index if transform=pandas (#25747)
pick 7cc5fae REL Update what's new for release 1.2.2 (#25778)
pick 1380e3c FIX Fixes bug OneHotEncoder's drop_idx_ when there are infrequent categories (#25589)
pick 451f212 DOC Fix description of roc_auc_score for average=None (#25779)
pick c26ee62808 FIX raise a better error in partial_dependence with mixed type categories (#25774)
pick 1ae0eb570b DOC Promote Tim Head to the Core Contributor Team (#25765)
drop 408f561b87 EFF Speed-up MiniBatchDictionaryLearning by avoiding multiple validation (#25490)
drop 20ad9cd62c MAINT Added Parameter Validation for metrics.make_scorer (#25760)
pick 86548dfdc2 FIX Raise an error when min_samples_split=1 in trees (#25744)
pick d92fba7b65 FIX add retry mechanism to handle quotechar in read_csv (#25511)
drop eae3f294d3 ENH Speed-up expected mutual information (#25713)
drop 21ed0815f4 CI Open issue when arm wheel fails on CirrusCI (#25620)
pick 2169b4d871 CI Disable network when SciPy requires it (#25743)
drop fdf2d7efb6 MAINT Define centralized generic, but with explicit precision, types (#25739)
drop de9b2585f8 MAINT parameter validation for sklearn.datasets.fetch_covtype (#25759)
drop 67ca4dda1d MAINT replace cnp.ndarray with memory views in sparsefuncs_fast (#25764)
pick 81f5c35290 DOC Move allowing pandas nullable dtypes to 1.2.2 (#25692)
drop 0729f24bdb MAINT Parameter Validation for metrics.get_scorer (#25738)
drop 2161d11e2a MAINT Parameters validation for feature_selection.r_regression (#25734)
drop 69e2d8aff9 MAINT Parameter Validation for feature_selection.f_regression (#25736)
drop dfda968f1d MAINT replace cnp.ndarray with memory views in _fast_dict (#25754)
drop 4180b079f7 MAINT Parameters validation for metrics.dcg_score (#25749)
drop 73c17decf9 MAINT Parameters validation for metrics.coverage_error (#25748)
drop 2c867b8f82 MAINT Parameters validation for metrics.label_ranking_loss (#25742)
drop d926ff130f MAINT remove np.product and inf/nan aliases in favor of canonical names (#25741)
drop c9810e80c2 API Use grid_values instead of pdp_values in partial_dependence (#25732)
drop fabe1606da API Deprecates values in partial_dependence in favor of pdp_values (#21809)
drop 96625cfbc0 MAINT Update pyparsing.py to use bool instead of double negation (#25724)
drop cac75813d3 API make PatchExtractor being a real scikit-learn transformer (#24230)
drop 080bf81491 MAINT Use float64 for accumulators in WeightVector* (#25721)
drop ef5c0879e1 MAINT Remove redundant sparse square euclidian distances function (#25731)
pick 41b4c63b8f DOC Makes navbar static (#25688)
pick 1a33e56552 FIX Improves error message in partial_fit when early_stopping=True (#25694)
drop cab725696c CI Adds permissions to workflows that use GITHUB_TOKEN (#25600)
drop a3305e688e MAINT Use newest NumPy C API in metrics._dist_metrics (#25702)
drop 725569f957 MAINT Clean dead code in build helpers (#25661)
drop 00f49ebf3d MAINT parameter validation for sklearn.datasets.dump_svmlight_file (#25726)
drop fa0866a8da MAINT Parameters validation for sklearn.metrics.matthews_corrcoef (#25712)
drop 7e15694559 MAINT Parameter Validation for feature_selection.f_classif (#25720)
drop f9ee1b4f34 MAINT Parameter Validation for feature_selection.chi2 (#25719)
drop de67a4420f ENH Let csr_row_norms support multi-thread (#25598)
pick ae4a1b1a78 FIX Allow OrdinalEncoder's encoded_missing_value set to the cardinality (#25704)
pick b4afbeeebe FIX Raise appropriate attribute error in ensemble (#25668)
drop 1a669d8202 ENH Support float32 in SGDClassifier and SGDRegressor (#25587)
pick 90d7e413e9 DOC Add scikit-learn-intelex to related projects (#23766)
drop 5ba1fee683 MAINT Remove -Wcpp warnings when compiling arrayfuncs (#25415)
drop 36b4c990e5 CI Stablize build with random_state (#25701)
drop 34fd458ef6 MAINT Parameter Validation for metrics.precision_score (#25708)
drop 3f990bceb6 MAINT Parameters validation for metrics.precision_recall_curve (#25698)
drop 5bb85454c5 MAINT Parameters validation for metrics.mean_absolute_percentage_error (#25695)
pick e6b4667531 DOC fix formatting typo in related_projects (#25706)
drop 1042757565 MAINT Replace deprecated cython conditional compilation (#25654)
pick 7b595569b2 FIX Allow negative tol in SequentialFeatureSelector (#25664)
drop 4b5cf19db1 MAINT Parameters validation for precision_recall_fscore_support (#25681)
pick 0d5f43466d DOC Add the custom compiler section back (#25667)
drop 81f823a088 MAINT Parameters validation for sklearn.metrics.jaccard_score (#25680)
drop f1f51f8425 MAINT Parameters validation for cluster.mean_shift (#25684)
pick 9c3794ddf3 MAINT Set random state for plot_anomaly_comparison (#25675)
pick d5df806c97 DOC Specify behaviour of None for TfIdfVectorizer max_features parameter (#25676)
pick 76c28285d3 DOC Specify behavior of None for CountVectorizer (#25678)
drop 4bd2c71343 MAINT Parameters validation for mean_pinball_loss (#25685)
drop 9c7c02bb54 MAINT Parameters validation for datasets.make_friedman1 (#25674)
drop 91885d4ef6 MAINT Parameters validation for metrics.max_error (#25679)
pick 610a0ce970 DOC unify usage of 'w.r.t.' (#25683)
pick 6671d604aa ENH Allows target to be pandas nullable dtypes (#25638)
drop 6adb209acd FIX renormalization of y_pred inside log_loss (#25299)
pick 102efa6cd9 DOC Update governance document for SLEP020 (#25663)
pick 0c42159547 DOC improve the `warm_start` glossary entry (#25523)
pick d9cfe3f6b1 MAINT Removes upper limit on setuptools (#25651)
pick d4e7158bca DOC modified the graph for better readability (#25644)
drop d590146255 FIX use const memory views in hist_gradient_boosting predictor (#25650)
pick 6169cc9b38 DOC fix typo in KMeans's param. (#25649)
drop 6df0f13a59 FIX report properly n_iter_ when warm_start=True (#25443)
drop 677a4cfef6 ENH Preserve DataFrame dtypes in transform for feature selectors (#25102)
drop dfe9e2e118 MAINT Remove Cython compilation warnings ahead of Cython3.0 release (#25621)
pick dd18df5f6a DOC Correctly docstring in StackingRegressor.fit_transform (#25599)
pick 245ac79641 FIX Fixes check_array nonfinite checks with ArrayAPI specification (#25619)
drop ee7dd363b6 MAINT Use newest NumPy C API in tree._criterion (#25615)
pick e89679b82d MAINT Check pyproject toml is consistent with min_dependencies (#25610)
pick 8c1a59925b DOC Places governance in navigation bar (#25618)
pick 22336afec6 DOC fix comment in plot_logistic_l1_l2_sparsity.py (#25633)
drop 616db5c032 TST Common test for checking estimator deserialization from a read only buffer (#25624)
drop 2ec6aebca5 ENH: Update KDTree, and example documentation (#25482)
pick 4ff92e03d7 DOC: fix typo in California Housing dataset description (#25613)
pick 872a084168 FIX error when deserialzing a Tree instance from a read only buffer (#25585)
drop 4810fabecf MAINT Adds comments and better naming into tree code (#25576)
drop 6f6b4bdd9c MAINT Parameters validation for sklearn.metrics.log_loss (#25577)
drop 28f8c87391 MAINT Removes ReadOnlyWrapper (#25586)
pick a09a62eda2 DOC improve stop_words description w.r.t. max_df range in CountVectorizer (#25489)
drop 4c8813e577 MAINT Remove ReadonlyArrayWrapper from DistanceMetric (#25553)
drop 2a2772a87b MAINT Remove ReadonlyArrayWrapper from _kmeans (#25554)
drop f9a1cf072d MAINT Remove ReadonlyArrayWrapper from _loss module (#25555)
pick 4f85597ac5 DOC Improve minor and bug-fix release processes documentation (#25457)
pick 32ad4b7405 FIX Enable setting of sub-parameters for deprecated base_estimator param (#25477)
pick 42294be24c DOC fix docstring of _plain_sgd (#25573)
pick 9b2cce5729 FIX ColumnTransformer supports empty selection for pandas output (#25570)
pick 57bb1acff8 DOC Change print format in TSNE example (#25569)
drop 584d413fec MAINT Replace cnp.ndarray with memory views in sklearn.tree._tree (where possible) (#25540)
drop aae5c83554 ENH Adds `class_names` to `tree.export_text` (#25387)
drop 7970d78cfc MAINT Parameters validation for sklearn.metrics.f1_score (#25557)
drop cd25abee0a MAINT ensure that pos_label support all possible types (#25317)
pick 1714eedd60 DOC Add docstring example to make_regression (#25551)
pick 4170b0f1f1 DOC Add pynndescent to Approximate nearest neighbors in TSNE example (#25480)
pick 7917117eda MAINT Remove travis ci config and related doc (#25562)
drop 05c0e088c6 ENH BaseLabelPropagation to accept sparse matrices (#19664)
pick baefe83933 FIX BisectingKMeans crashes randomly (#25563)
pick 53c77135f6 DOC Update docs for KMeans (#25546)
pick 320e392cdf DOC Update MLPRegressor docs (#25556)
drop 7671e54b8b MAINT Parameters validation for sklearn.datasets.fetch_kddcup99 (#25463)
drop 81f3b63b00 MAINT Parameters validation for spectral_clustering (#25378)
drop 4be28d4dff MAINT Parameter validation for sklearn.metrics.d2_pinball_score (#25414)
drop ba16dbe72b MAINT Parameters validation for reconstruct_from_patches_2d (#25384)
pick f8281fad0f DOC: remove incorrect statement (#25544)
drop 4acd91d881 MAINT Clean-up comments and rename variables in `_middle_term_sparse_sparse_{32, 64}` (#25449)
drop 83a877416b MNT Expose allow_nan tag in bagging (#25506)
drop 225f14cc43 MAINT Parameters validation for sklearn.datasets.make_classification (#25474)
pick c7024463bf DOC add missing trailing colon (#25542)
pick defff702af DOC Fix grammatical mistake in `mixture` module (#25541)
pick f9637ee0ae FIX Fixes linux ARM CI on CirrusCI (#25536)
drop 67450f5638 MAINT Remove -Wcpp warnings from sklearn.utils._seq_dataset (#25406)
pick 3099d27523 CI Upload ARM wheels from CirrusCI to nightly and staging index (#25513)
pick d9cf5c9e98 CI Allow cirrus arm tests to run with cd build commit tag (#25514)
pick 681e8e2b00 MAINT add more intuition on OAS computation based on literature (#23867)
drop 2620a5545a MAINT Remove -Wsign-compare warnings when compiling sklearn.tree._tree (#25507)
drop 7b13a8f120 FEA Add Gamma deviance as loss function to HGBT (#22409)
pick 6f364ee61c FIX make IsotonicRegression always predict NumPy arrays (#25500)
pick 6822e633bf DOC Fixes sphinx search on website (#25504)
pick 4db04923a7 TST Allow callables as valid parameter regarding cloning estimator (#25498)
drop f965fcc063 ENH csr_row_norms optimization (#24426)
pick 41a960c8fa DOC more didactic example of bisecting kmeans (#25494)
drop cabe027497 MAINT remove -Wcpp warnings when compiling sklearn.preprocessing._csr_polynomial_expansion (#25041)
pick b580d34c79 DOC update description of X in `FunctionTransformer.transform()`  (#24844)
pick bb3a07f5ae CI add linter display name (#25485)
drop bac71b71fc DOC Adds CirrusCI badge to readme (#25483)
drop 8640ed7b00 MAINT dynamically expose kulsinski and remove support in BallTree (#25417)
drop b69abf5121 FIX Support readonly sparse datasets for `manhattan_distances`  (#25432)
drop c58ca7dec4 MAINT Remove -Wcpp warnings when compiling sklearn.decomposition._online_lda_fast (#25020)
pick e2e705021e TST Sets random_state for test_logistic.py (#25446)
drop daa84491b7 MAINT Update version number to 1.2.1 in SECURITY.md (#25471)
pick 08d168346e CI Include linting in CircleCI (#25475)
drop 449940985c MAINT Parameters validation for additive_chi2_kernel (#25424)
drop 2c555ef272 MAINT Validate parameter for `sklearn.cluster.cluster_optics_xi` (#25385)
drop 8e0f54fe1e DOC Update news footer for 1.2.1 (#25472)
pick de54caafcf CI Build doc on CircleCI (#25466)
drop b37c1b146e TST reduce warnings in test_logistic.py (#25469)
drop 1f12941e71 MAINT refactor spectral_clustering to call SpectralClustering (#25392)
drop 99562100e9 EFF Improve IsolationForest predict time (#25186)
drop bd1d165789 ENH Raise NotFittedError in get_feature_names_out for estimators that use ClassNamePrefixFeatureOutMixin and SelectorMixin (#25308)
drop b2fe9746a8 FIX fix faulty test in `cross_validate` that used the wrong estimator (#25456)
drop 9b53739648 DOC Reorder whats_new/v1.2.rst (#25461)
pick e2318ecb87 DOC Make MeanShift documentation clearer (#25305)
drop ed9629a063 DOC Update date and contributors list for v1.2.1 (#25459)
drop d85b1d3302 ENH Raise NotFittedError in get_feature_names_out for MissingIndicator, KBinsDiscretizer, SplineTransformer, DictVectorizer (#25402)
pick aea3cfbf41 DOC Fix typo in alpha parameter description (#25453)

smith558 and others added 30 commits March 7, 2023 16:18
@smith558 @jeremiedbb
DOC Fix typo in alpha parameter description (scikit-learn#25453)
dc70ce3
@remilvus @glemaitre @jeremiedbb
DOC Make MeanShift documentation clearer (scikit-learn#25305)
b269f07 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@lesteve @jeremiedbb
CI Build doc on CircleCI (scikit-learn#25466)
6d0aff3
@thomasjpfan @jeremiedbb
CI Include linting in CircleCI (scikit-learn#25475)
74b8784
@thomasjpfan @jeremiedbb
TST Sets random_state for test_logistic.py (scikit-learn#25446)
2c3b0d8
@lesteve @jeremiedbb
CI add linter display name (scikit-learn#25485)
2b5faf7
@rprkh @jeremiedbb
DOC update description of X in FunctionTransformer.transform() (sci…
dbcf67a 
…kit-learn#24844)
@GaelVaroquaux @ogrisel
@ArturoAmorQ @jeremiedbb
DOC more didactic example of bisecting kmeans (scikit-learn#25494)
9df354b 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@jjerphan @glemaitre
@lesteve @betatim @jeremiedbb
TST Allow callables as valid parameter regarding cloning estimator (s…
d46d816 
…cikit-learn#25498)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: From: Tim Head <betatim@gmail.com>
@thomasjpfan @jeremiedbb
DOC Fixes sphinx search on website (scikit-learn#25504)
de9ef18
@glemaitre @thomasjpfan @jeremiedbb
FIX make IsotonicRegression always predict NumPy arrays (scikit-learn…
9a5e673 
…#25500)



Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@Micky774 @glemaitre @jeremiedbb
MAINT add more intuition on OAS computation based on literature (scik…
eceae05 
…it-learn#23867)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@thomasjpfan @jeremiedbb
CI Allow cirrus arm tests to run with cd build commit tag (scikit-lea…
38c8264 
…rn#25514)
@thomasjpfan @ogrisel @jeremiedbb
CI Upload ARM wheels from CirrusCI to nightly and staging index (scik…
d8fe868 
…it-learn#25513)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@thomasjpfan @jeremiedbb
FIX Fixes linux ARM CI on CirrusCI (scikit-learn#25536)
1bc20d6
@davidblnc @jeremiedbb
DOC Fix grammatical mistake in mixture module (scikit-learn#25541)
1256c58
@changyaochen @jeremiedbb
DOC add missing trailing colon (scikit-learn#25542)
d04bae5
@partev @jeremiedbb
DOC: remove incorrect statement (scikit-learn#25544)
24ba13d
@it176131 @jeremiedbb
DOC Update MLPRegressor docs (scikit-learn#25556)
d85baef 
Co-authored-by: Ian Thompson <ian.thompson@hrblock.com>
@sanjail3 @jeremiedbb
DOC Update docs for KMeans (scikit-learn#25546)
aa7fb99 
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@jeremiedbb
FIX BisectingKMeans crashes randomly (scikit-learn#25563)
42beabc 
Fixes scikit-learn#25505
@ogrisel @jeremiedbb
MAINT Remove travis ci config and related doc (scikit-learn#25562)
f53e47a
@ArturoAmorQ @ogrisel @jeremiedbb
DOC Add pynndescent to Approximate nearest neighbors in TSNE example (s…
4d1fb47 
…cikit-learn#25480)


Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@ArturoAmorQ @thomasjpfan @jeremiedbb
DOC Add docstring example to make_regression (scikit-learn#25551)
9d68fc6 
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@ArturoAmorQ @ogrisel @jeremiedbb
DOC Change print format in TSNE example (scikit-learn#25569)
6e36d3e 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@thomasjpfan @jjerphan @jeremiedbb
FIX ColumnTransformer supports empty selection for pandas output (sci…
6637b79 
…kit-learn#25570)

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
@lorentzenchr @jeremiedbb
DOC fix docstring of _plain_sgd (scikit-learn#25573)
27cdffd
@betatim @jeremiedbb
FIX Enable setting of sub-parameters for deprecated base_estimator pa…
5487203 
…ram (scikit-learn#25477)
@jjerphan @ogrisel
@thomasjpfan @jeremiedbb
DOC Improve minor and bug-fix release processes documentation (scikit…
715ca67 
…-learn#25457)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Jérémie du Boisberranger <jeremiedbb@yahoo.fr>
@rprkh @jeremiedbb
DOC improve stop_words description w.r.t. max_df range in CountVector…
b32d0c1 
…izer (scikit-learn#25489)
tabeak and others added 15 commits March 7, 2023 16:33
@tabeak @jeremiedbb
MAINT Set random state for plot_anomaly_comparison (scikit-learn#25675)
51e1499
@jeremiedbb @thomasjpfan
DOC Add the custom compiler section back (scikit-learn#25667)
53d2738 
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@jeremiedbb
FIX Allow negative tol in SequentialFeatureSelector (scikit-learn#25664)
a4ff402
@jack-mcivor @jeremiedbb
DOC fix formatting typo in related_projects (scikit-learn#25706)
7449a20
@MaxHalford @adrinjalali
@thomasjpfan @jeremiedbb
DOC Add scikit-learn-intelex to related projects (scikit-learn#23766)
9d055a4 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@jeremiedbb
FIX Raise appropriate attribute error in ensemble (scikit-learn#25668)
f1315f5
@thomasjpfan @jeremiedbb
FIX Allow OrdinalEncoder's encoded_missing_value set to the cardinali…
343a40a 
…ty (scikit-learn#25704)
@thomasjpfan @jeremiedbb
FIX Improves error message in partial_fit when early_stopping=True (s…
5212485 
…cikit-learn#25694)

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@thomasjpfan @jeremiedbb
DOC Makes navbar static (scikit-learn#25688)
1f08e6a
@thomasjpfan @jeremiedbb
DOC Move allowing pandas nullable dtypes to 1.2.2 (scikit-learn#25692)
8f5b123
@thomasjpfan @jeremiedbb
CI Disable network when SciPy requires it (scikit-learn#25743)
e6aaa99
@glemaitre @jeremiedbb
FIX add retry mechanism to handle quotechar in read_csv (scikit-learn…
7f49057 
…#25511)
@jeremiedbb
FIX Raise an error when min_samples_split=1 in trees (scikit-learn#25744
f46966e 
)
@jjerphan @jeremiedbb
DOC Promote Tim Head to the Core Contributor Team (scikit-learn#25765)
35c2fde
@glemaitre @jeremiedbb
FIX raise a better error in partial_dependence with mixed type catego…
c26ee62 
…ries (scikit-learn#25774)

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@github-actions github-actions bot added the cython label Mar 7, 2023
@jeremiedbb
Copy link
Member Author

Waiting for #25589

@jeremiedbb jeremiedbb mentioned this pull request Mar 7, 2023
Merged
@thomasjpfan
Copy link
Member

thomasjpfan commented Mar 8, 2023 •
edited

Thank you for starting the release process!

#25779 is a simple doc fix to cherry pick

adam-handke and others added 4 commits March 8, 2023 11:51
@adam-handke @jeremiedbb
DOC Fix description of roc_auc_score for average=None (scikit-learn#2…
75c1bdf 
…5779)
@thomasjpfan @glemaitre
@jeremiedbb @jjerphan
FIX Fixes bug OneHotEncoder's drop_idx_ when there are infrequent cat…
b000feb 
…egories (scikit-learn#25589)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
@jeremiedbb
REL Update what's new for release 1.2.2 (scikit-learn#25778)
4f34af3
@jeremiedbb
[cd build]
aef0e11
@thomasjpfan
Copy link
Member

Ah I forgot to add #25747 to the 1.2.2 milestone. Is it too late to make it in?

@jeremiedbb
Copy link
Member Author

All backported, All green, Let's merge :)

@jeremiedbb jeremiedbb merged commit 0ea5793 into scikit-learn:1.2.X Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cython No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet