Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Update "About Us" #25435

Merged
merged 4 commits into from Jan 20, 2023
Merged

DOC Update "About Us" #25435

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1edf52d
CI Update generate_authors_table
jjerphan Jan 19, 2023
f00463b
DOC Update Authors' list
jjerphan Jan 19, 2023
2b50b6b
Merge branch 'main' into doc/update-about-us
jjerphan Jan 19, 2023
e1048d8
Respect Maxwell Liu's name
jjerphan Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions build_tools/generate_authors_table.py
View file
Open in desktop
Expand Up @@ -75,7 +75,7 @@ def get_contributors():
# add missing contributors without GitHub accounts
members |= {"Angel Soler Gollonet"}
# remove CI bots
members -= {"sklearn-ci", "sklearn-wheels"}
members -= {"sklearn-ci", "sklearn-wheels", "sklearn-lgtm"}
contributor_experience_team -= (
core_devs # remove ogrisel from contributor_experience_team
)
Expand Down Expand Up @@ -161,14 +161,14 @@ def generate_table(contributors):
lines.append(" <p>%s</p>" % (contributor["name"],))
lines.append(" </div>")
lines.append(" </div>")
return "\n".join(lines)
return "\n".join(lines) + "\n"


def generate_list(contributors):
lines = []
for contributor in contributors:
lines.append("- %s" % (contributor["name"],))
return "\n".join(lines)
return "\n".join(lines) + "\n"


if __name__ == "__main__":
Expand Down
4 changes: 2 additions & 2 deletions doc/authors_emeritus.rst
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@
- Peter Prettenhofer
- (Venkat) Raghav, Rajagopalan
- Jacob Schreiber
- Du Shiqiao
- 杜世橋 Du Shiqiao
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall well, I think that the rendering was not fine with Chinese characters. We need to check before merging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and the rendering is fine

- Jake Vanderplas
- David Warde-Farley
- Ron Weiss
- Ron Weiss
2 changes: 1 addition & 1 deletion doc/communication_team.rst
View file
Open in desktop
Expand Up @@ -13,4 +13,4 @@
<a href='https://github.com/francoisgoupil'><img src='https://avatars.githubusercontent.com/u/98105626?v=4' class='avatar' /></a> <br />
<p>francoisgoupil</p>
</div>
</div>
</div>
2 changes: 1 addition & 1 deletion doc/communication_team_emeritus.rst
View file
Open in desktop
@@ -1 +1 @@
- Reshama Shaikh
- Reshama Shaikh
24 changes: 12 additions & 12 deletions doc/contributor_experience_team.rst
View file
Open in desktop
Expand Up @@ -6,20 +6,20 @@
img.avatar {border-radius: 10px;}
</style>
<div>
<a href='https://github.com/alfaro96'><img src='https://avatars.githubusercontent.com/u/32649176?v=4' class='avatar' /></a> <br />
<p>Juan Carlos Alfaro Jiménez</p>
</div>
<div>
<a href='https://github.com/ArturoAmorQ'><img src='https://avatars.githubusercontent.com/u/86408019?v=4' class='avatar' /></a> <br />
<p>Arturo Amor</p>
</div>
<div>
<a href='https://github.com/lucyleeow'><img src='https://avatars.githubusercontent.com/u/23182829?v=4' class='avatar' /></a> <br />
<p>Lucy Liu</p>
<a href='https://github.com/betatim'><img src='https://avatars.githubusercontent.com/u/1448859?v=4' class='avatar' /></a> <br />
<p>Tim Head</p>
</div>
<div>
<a href='https://github.com/MaxwellLZH'><img src='https://avatars.githubusercontent.com/u/16646940?v=4' class='avatar' /></a> <br />
<p>Maxwell Liu</p>
<a href='https://github.com/alfaro96'><img src='https://avatars.githubusercontent.com/u/32649176?v=4' class='avatar' /></a> <br />
<p>Juan Carlos Alfaro Jiménez</p>
</div>
<div>
<a href='https://github.com/lucyleeow'><img src='https://avatars.githubusercontent.com/u/23182829?v=4' class='avatar' /></a> <br />
<p>Lucy Liu</p>
</div>
<div>
<a href='https://github.com/jmloyola'><img src='https://avatars.githubusercontent.com/u/2133361?v=4' class='avatar' /></a> <br />
Expand All @@ -34,6 +34,10 @@
<p>Chiara Marmo</p>
</div>
<div>
<a href='https://github.com/MaxwellLZH'><img src='https://avatars.githubusercontent.com/u/16646940?v=4' class='avatar' /></a> <br />
<p>Maxwell</p>
jjerphan marked this conversation as resolved.
Show resolved Hide resolved
</div>
<div>
<a href='https://github.com/norbusan'><img src='https://avatars.githubusercontent.com/u/1735589?v=4' class='avatar' /></a> <br />
<p>Norbert Preining</p>
</div>
Expand All @@ -45,8 +49,4 @@
<a href='https://github.com/albertcthomas'><img src='https://avatars.githubusercontent.com/u/15966638?v=4' class='avatar' /></a> <br />
<p>Albert Thomas</p>
</div>
<div>
<a href='https://github.com/betatim'><img src='https://avatars.githubusercontent.com/u/1448859?v=4' class='avatar' /></a> <br />
<p>Tim Head</p>
</div>
</div>