New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT Update to Pyodide 0.24 #27405
MNT Update to Pyodide 0.24 #27405
Conversation
duplicate of #27346 ? |
Kind of, I think #27346 tries to do more than this PR. |
Thanks for the PR, a few comments:
|
It is pretty cool (and makes sense :D) that there is just that one thing to change to get a different version of pyodide for our built docs. Almost too easy. Should we merge this PR then to get the example gallery working with 1.3.0? @glemaitre if we merge this, do I need to do something to get it included in the 1.3.1 release? (this time maybe pinging you is enough, but in the future is there something I can do?) |
Let me test it locally before merging (due to CircleCI limitations the JupyterLite button does not work in CircleCI artifacts 😢) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming Loic's local build yield the expected result, LGTM as well.
So trying to build locally and test the JupyterLite, it seems there are some issues that need to be looked at. The first one is that Pyodide 0.24 has been fixed in jupyterlite-pyodide-kernel 0.1.2 (see jupyterlite/pyodide-kernel#62). Trying to update the lock file I then get issues during the sphinx doc build which I don't understand yet ... |
I pushed a lock file update for the doc build and enabled auto-merge. The local issues I was noticing were due to something weird in my local setup ... |
This needs to be backported to 1.3.X probably. |
FYI, I double-checked and it seems like this works on the scikit-learn dev website: https://scikit-learn.org/dev/lite/lab/?path=auto_examples/release_highlights/plot_release_highlights_1_3_0.ipynb scikit-learn version is indeed 1.3.0. |
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Reference Issues/PRs
closes ##26763
What does this implement/fix? Explain your changes.
This changes the version of pyodide used to 0.24.0.
Any other comments?
I grepped the repo for 0.23.4 (previous version) and pyodide to find all the places where the version needs changing. These are the only places I found. Does someone know if there are more?