MAINT make sphinx conf more lenient towards missing jupyterlite #26705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
commented
Jun 26, 2023
|
Ah could this be the cause of the failure: #26709 |
|
Indeed, this is the same failure. Thanks for pointing out 0.10.1 because I was going to use 0.11.0 instedad. |
|
doc-min-dependencies passes, merging, thanks! |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jun 29, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Jun 29, 2023
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #26709
I am not really sure why but the min-doc build started to fail. It should be linked to #26627 because we bumped the version of
sphinxto 6.0.0.It would require to bump
sphinx-gallery. To avoid bumping to the latest release 0.13 knows how to dealjupyterlite, we need to be lenient with the configuration and only add key in the conf if the extension is installed (otherwise, it fails locally).