Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Sphinx gallery bug after Sphinx min dependency increased to 6.0.0 #26709

Closed
lucyleeow opened this issue Jun 27, 2023 · 1 comment · Fixed by #26705
Closed

MAINT: Sphinx gallery bug after Sphinx min dependency increased to 6.0.0 #26709

lucyleeow opened this issue Jun 27, 2023 · 1 comment · Fixed by #26705
Labels
Build / CI Documentation

Comments

@lucyleeow
Copy link
Member

lucyleeow commented Jun 27, 2023 •
edited

Sphinx gallery error when resolving links:

TypeError: list indices must be integers or slices, not str

See CI: https://app.circleci.com/pipelines/github/scikit-learn/scikit-learn/48046/workflows/c2bbef06-cb62-416d-98c5-29b211a01b93/jobs/240437 from #26677

This bug was introduced after sphinx 4.3.0 (thus introduced after #26627) and fixed in sphinx gallery 0.10.1, see: sphinx-gallery/sphinx-gallery#879

Can we increase the min dep of sphinx gallery to 0.10.1 ?
@lucyleeow lucyleeow changed the title MAINT: Sphinx gallery bug after Sphinx min increased to 6.0.0 MAINT: Sphinx gallery bug after Sphinx min dependency increased to 6.0.0 Jun 27, 2023
@lucyleeow lucyleeow mentioned this issue Jun 27, 2023
Merged
@glemaitre
Copy link
Member

#26705 should resolve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build / CI Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT make sphinx conf more lenient towards missing jupyterlite glemaitre/scikit-learn
2 participants
@glemaitre @lucyleeow