Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore flake8 B905 + improve bug report template #297

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

Saransh-cpp
Copy link
Collaborator

Description

Kindly take a look at CONTRIBUTING.md.

Please describe the purpose of this pull request. Reference and link to any relevant issues or pull requests.

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Request for the required change ?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission pass doctests? ($ xdoctest ./src/vector or $ nox -s doctests)

Before Merging

  • Summarize commit messages into a brief review of the Pull request.

@Saransh-cpp Saransh-cpp added this to the v1.0.0 milestone Dec 9, 2022
@Saransh-cpp Saransh-cpp added bug The problem described is something that must be fixed docs Improvements or additions to documentation labels Dec 9, 2022
@Saransh-cpp Saransh-cpp merged commit 6a6386a into scikit-hep:main Dec 9, 2022
@Saransh-cpp Saransh-cpp deleted the fix-pre-commit branch December 9, 2022 13:20
@henryiii
Copy link
Member

henryiii commented Dec 9, 2022

I recommend this: wntrblm/nox#678

@Saransh-cpp
Copy link
Collaborator Author

Thanks! On it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The problem described is something that must be fixed docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants