Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Protect RenderBlank() and IsFinished() with the lock #164

Merged
merged 1 commit into from Feb 24, 2024
Merged

fix: Protect RenderBlank() and IsFinished() with the lock #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions progressbar.go
View file
Open in desktop
Expand Up @@ -456,6 +456,9 @@ func (p *ProgressBar) String() string {

// RenderBlank renders the current bar state, you can use this to render a 0% state
func (p *ProgressBar) RenderBlank() error {
p.lock.Lock()
defer p.lock.Unlock()

if p.config.invisible {
return nil
}
Expand Down Expand Up @@ -628,6 +631,9 @@ func (p *ProgressBar) ChangeMax64(newMax int64) {

// IsFinished returns true if progress bar is completed
func (p *ProgressBar) IsFinished() bool {
p.lock.Lock()
defer p.lock.Unlock()

return p.state.finished
}

Expand Down