add binary literals support #3543
Conversation
kasiaMarek
force-pushed
the
binary-literals
branch
from
02071d3
to
030e30b
Compare
There was a problem hiding this comment.
Lgtm! @kitbellew do you see any issues? Should be a noop change for scalafmt
|
i looked at the two threads on scala repo, it seems that the feature is only in 2.13 but not in dotty (and so definitely not in 3.0-2 but could be added later to whatever next milestone is).
|
| @@ -30,7 +30,7 @@ The exact test command to run tests depends on what you are working on: | |||
| - `testsJVM/slow:test`: run slow integration tests for semantic APIs. | |||
| - `testsJVM/all:test`: run all tests, both fast and slow. | |||
|
|
|||
| Tips to make your edit/test/debug worflow as productive as possible: | |||
| Tips to make your edit/test/debug workflow as productive as possible: | |||
There was a problem hiding this comment.
good change but unrelated. why not submit as a separate pr?
scalameta/dialects/shared/src/main/scala/scala/meta/dialects/package.scala
Show resolved
Hide resolved
I think that is what I did. |
|
It is worth noting that this is not something that is present in any released version of Scala 3. It will become part of the language in 3.5. |
|
It's currently in the Scala3Future dialect, so this should be safe |
SIP: https://docs.scala-lang.org/sips/binary-integer-literals.html
Scala 2: scala/scala#10656
Scala 3: scala/scala3#19551