Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Xlint:pattern-shadow to lint pattern varids which are backquotable #8806

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Add -Xlint:pattern-shadow to lint pattern varids which are backquotable #8806

merged 11 commits into from
Jan 17, 2024

Commits on Jan 16, 2024

  1. Lint shadowing pattern variables

    @som-snytt
    som-snytt committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    b7eed1a View commit details
    Browse the repository at this point in the history

  2. Tweak library

    @som-snytt
    som-snytt committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ac6af40 View commit details
    Browse the repository at this point in the history

  3. Tweak reflect

    @som-snytt
    som-snytt committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    e31f6df View commit details
    Browse the repository at this point in the history

  4. Tweak nsc

    @som-snytt
    som-snytt committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    b8b4442 View commit details
    Browse the repository at this point in the history

  5. Tweak more

    @som-snytt
    som-snytt committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    2178255 View commit details
    Browse the repository at this point in the history

  6. Tweak junit

    @som-snytt
    som-snytt committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    1d03b6f View commit details
    Browse the repository at this point in the history

  7. Handle typed selector

    @som-snytt
    som-snytt committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ab695d0 View commit details
    Browse the repository at this point in the history

  8. Partial Functions resisting

    @som-snytt
    som-snytt committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    a964d3d View commit details
    Browse the repository at this point in the history

  9. Tweak junit

    @som-snytt
    som-snytt committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    3ddddbc View commit details
    Browse the repository at this point in the history

  10. Add line number if not a member

    @som-snytt
    som-snytt committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    43c386c View commit details
    Browse the repository at this point in the history

  11. Loosey-goosey implication in selector 

    If the shadowed element appears anywhere in the selector expression,
don't warn about the shadowing pattern variable.

This means that there might be no type relationship between the two
symbols, and that elements of tuples might be swapped, i.e.,
there is no ordering relationship between arguments in the selector
and in the pattern.

For example, `(x, y) match { case (y, x) => }`.

For example, `t.toString match { case t => }`.
    @som-snytt
    som-snytt committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    e534c44 View commit details
    Browse the repository at this point in the history