Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recent regression in implicit search (don't include inPackagePrefix in ImplicitInfo equality) #10685

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Feb 8, 2024

This lead to some implicit inference failures in the community build.

scala/community-build#1710 (comment)

Follow-up for #10621

This lead to some implicit inference failures in the community build.
@scala-jenkins scala-jenkins added this to the 2.13.14 milestone Feb 8, 2024
@som-snytt
Copy link
Contributor

I was looking forward to spending the morning debugging that issue, but instead I'll spend it understanding this tweak.

@lrytz
Copy link
Member Author

lrytz commented Feb 8, 2024

image

@lrytz
Copy link
Member Author

lrytz commented Feb 8, 2024

https://github.com/etorreborre/specs2/blob/c9049ff7b80d67203caa2801676296f1bc3eed19/shapeless/src/main/scala/org/specs2/shapeless/Projection.scala#L51

https://github.com/milessabin/shapeless/blob/c67ef298aed6727b1290357b9da252b31f441c7f/core/shared/src/main/scala/shapeless/package.scala#L43

Not sure what to make of it. The implicit was found once in the package, once in the package object. Maybe because the corresponding trait trait =:!= is also defined in the package object.

@SethTisue SethTisue modified the milestones: 2.13.14, 2.13.13 Feb 8, 2024
@SethTisue SethTisue added the prio:blocker release blocker (used only by core team, only near release time) label Feb 8, 2024
@SethTisue
Copy link
Member

I'll do a local, partial community build run shortly to see how many of the other failing projects this progresses.

@SethTisue SethTisue self-assigned this Feb 8, 2024
@SethTisue SethTisue merged commit ffc0297 into scala:2.13.x Feb 8, 2024
3 checks passed
@SethTisue SethTisue removed the prio:blocker release blocker (used only by core team, only near release time) label Feb 8, 2024
@SethTisue
Copy link
Member

This fixed all 5 failing projects. We'll have full results tomorrow.

@SethTisue
Copy link
Member

Whole community build is green.

@SethTisue SethTisue changed the title Don't include inPackagePrefix in ImplicitInfo equality Fix recent regression in implicit search (don't include inPackagePrefix in ImplicitInfo equality) Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants