Add -Vcyclic to improve reporting of "cyclic reference" errors
#10680
+128
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/7808-synth-message
branch
from
c04850d to
f8708b2
Compare
|
Dotty also has message about symbols involved in the cycle IIRC. This just uses IIRC here the lock/unlock are not symmetric? |
|
I'm concerned about performance ( How about a single |
|
it ought to be behind a diagnostic flag. is where I learned about |
som-snytt
changed the title
som-snytt
force-pushed
the
issue/7808-synth-message
branch
2 times, most recently
from
c449be6 to
4a80252
Compare
lrytz
reviewed
Apr 3, 2024
|
|
||
| val badsym = if (!sym.isSynthetic) sym else { | ||
| val organics = trace.filter(!_.isSynthetic) | ||
| if (organics.length == 0) sym |
There was a problem hiding this comment.
How about adding something to the error message here? $sym is synthetic; use -Vcyclic to find which definition needs an explicit type.
There was a problem hiding this comment.
apparently, I followed that suggestion.
som-snytt
force-pushed
the
issue/7808-synth-message
branch
2 times, most recently
from
6781f7a to
b8901c0
Compare
som-snytt
changed the title
lrytz
reviewed
May 21, 2024
som-snytt
force-pushed
the
issue/7808-synth-message
branch
from
b8901c0 to
ecdaecc
Compare
som-snytt
changed the title
SethTisue
changed the title
-Vcyclic to improve reporting of "cyclic reference" errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Vcyclicimproves reporting of "cyclic reference" errors.It enables "tracing" of symbol locking to show which symbols were involved in the cycle.
This is also helpful when a synthetic symbol name is reported, since that name is not meaningful.
Look for a non-synthetic symbol to blame.
Fixes scala/bug#7808