Support certain Java libraries compiled on JDK 21 #10675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
added
the
prio:blocker
SethTisue
changed the title
CONSTANT_Dynamic in constant pool
|
I thought the guy who does those forward merges to 2.13 would get around to it eventually. |
lrytz
approved these changes
Jan 26, 2024
SethTisue
added a commit
to SethTisue/dotty
that referenced
this pull request
Jan 26, 2024
forward-port of scala/scala#10675 references scala/bug#12396 fixes scala#19527
SethTisue
added a commit
to SethTisue/dotty
that referenced
this pull request
Jan 26, 2024
forward-port of scala/scala#10675 and scala/scala#8595 references scala/bug#12396 and scala/bug#11635 fixes scala#19527 ("bad constant pool tag 17") also fixes unreported potential "bad constant pool tag 19" and "bad constant pool tag 20" errors
SethTisue
added a commit
to scala/scala3
that referenced
this pull request
Jan 30, 2024
forward-port of scala/scala#10675 and scala/scala#8595 references scala/bug#12396 and scala/bug#11635 fixes #19527 ("bad constant pool tag 17") also fixes unreported potential "bad constant pool tag 19" and "bad constant pool tag 20" errors
SethTisue
added
release-notes
SethTisue
changed the title
CONSTANT_Dynamic in constant pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes certain Java libraries compiled using Java 21 usable from Scala — libraries that use
switchin a certain way.The fix is to our classfile reader, to recognize
CONSTANT_Dynamicwhen it appears in the constant pool.Fixes scala/bug#12936
Implementation notes
Previous PR in this vein, for comparison: #8289
I verified that
partest test/files/pos/t12396was failing locally on JDK 21 but now passes.PR validation runs on Java 8, so it will not run the test, but it will run at https://github.com/scala/scala/actions after the PR is merged; our GitHub Actions config has
java: [8, 11, 17, 21]