Prefer NonFatal to catch-all

scala · Dec 7, 2023 · 47e1f65 · 47e1f65
1 parent bee5534
commit 47e1f65
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/compiler/scala/tools/nsc/classpath/DirectoryClassPath.scala b/src/compiler/scala/tools/nsc/classpath/DirectoryClassPath.scala
@@ -23,6 +23,7 @@ import scala.tools.nsc.CloseableRegistry
 import scala.tools.nsc.classpath.PackageNameUtils.{packageContains, separatePkgAndClassNames}
 import scala.tools.nsc.util.{ClassPath, ClassRepresentation, EfficientClassPath}
 import scala.util.Properties.{isJavaAtLeast, javaHome}
+import scala.util.control.NonFatal
 import FileUtils._
 
 /**
@@ -168,7 +169,7 @@ object JrtClassPath {
         List(classPath)
       }
     } catch {
-      case _: Throwable => Nil
+      case NonFatal(_) => Nil
     }
   private def createJrt(closeableRegistry: CloseableRegistry): List[JrtClassPath] =
     try {

diff --git a/test/files/neg/unsafe.scala b/test/files/neg/unsafe.scala
@@ -2,7 +2,7 @@
 // scalac: --release:8 -Yopen-packages:java.lang
 // javaVersion: 19+
 
-// -Yunsafe opens packages but does not override class definitions
+// -Yopen-packages opens packages but does not override class definitions
 // because ct.sym comes first
 
 class C {