Add flag max-buffer-size #505
Conversation
|
Hey @FabioPinheiro, you can use this snapshot release to test the feature if you want before merging this PR. |
|
Hey @FabioPinheiro, did you manage to test this? |
|
Hey @alejandrohdezma I configured the GitHub action with the setting Where previously it was So I think it's working as expected |
|
Perfect! Thank you! I'll merge as soon as CI passes 😊 |
|
A snapshot release has been created as You can test it out with: uses: scala-steward-org/scala-steward-action@snapshots/505It will be automatically recreated on any change to this PR. |
|
This wraps the `fs2.text.LineTooLongException` that is thrown by `fs2.text.linesLimited` which is used in `process.slurp` to enrich the error message with more helpful information. Instead of this: ``` 2023-07-19 15:34:45,215 ERROR Steward scala-steward-org/test-repo-1 failed fs2.text$LineTooLongException: Max line size is 50 but 79 chars have been accumulated at fs2.text$.$anonfun$linesImpl$1(text.scala:553) ... ``` we now get this: ``` 2023-07-19 16:02:41,546 ERROR Steward scala-steward-org/test-repo-1 failed org.scalasteward.core.io.process$ProcessLineTooLongException: 'mvn --batch-mode dependency:list -DexcludeTransitive=true' outputted a line longer than 50 chars. If the process executed normally and the buffer size is just too small, you can increase it with the --max-buffer-size command-line option and/or open a pull request in https://github.com/scala-steward-org/scala-steward that increases the default buffer size. [INFO] Scanning for projects... [INFO] [INFO] ----------------------< com.mycompany.app:my-app >---------------------- [INFO] Building my-app 1.0-SNAPSHOT at org.scalasteward.core.io.process$$anonfun$1.applyOrElse(process.scala:69) ... Caused by: fs2.text$LineTooLongException: Max line size is 50 but 65 chars have been accumulated at fs2.text$.$anonfun$linesImpl$1(text.scala:553) ... ``` which includes now * the command that led to the exception * the reason why this exception was raised (outputted line is too long) * guidance how to avoid it * the output of the process before the exception is raised * the original exception This change was motivated by the unhelpful error shown in scala-steward-org/scala-steward-action#505 (comment).
Use the latest option scala-steward-org/scala-steward-action#505 to address #2
I would like to add the scala-steward's flag
max-buffer-size.But I have no idea how to test this.