Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.10.x] Exclude custom extra from pom dependency #451

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Oct 7, 2024

Fix sbt/sbt#7710

Custom extra attributes are not used for resolution. We remove them from POM extraDependencyAttributes, so they don't mess up the conflict resolution in Coursier (or Maven).

For instance this POM file contains too many dependency extra attributes: e:info.apiURL, e:info.versionScheme and e:info.releaseNotesUrl should be ignored

<extraDependencyAttributes xml:space="preserve">
+e:info.apiURL:#@#:+https://www.javadoc.io/doc/com.armanbilge/sbt-scala-native-config-brew_2.12/0.3.0/:#@#:
+e:sbtVersion:#@#:+1.0:#@#:
+e:info.releaseNotesUrl:#@#:
+https://github.com/armanbilge/scala-native-config-brew/releases/tag/v0.3.0:#@#:
+module:#@#:+sbt-scala-native-config-brew_2.12_1.0:#@#:
+e:scalaVersion:#@#:+2.12:#@#:$
+e:info.versionScheme:#@#:+early-semver:#@#:
+organisation:#@#:+com.armanbilge:#@#:
+branch:#@#:+@#:NULL:#@:#@#:
+revision:#@#:+0.3.0:#@#:
+e:sbtVersion:#@#:+1.0:#@#:
+module:#@#:+sbt-typelevel-github-actions_2.12_1.0:#@#:
+e:scalaVersion:#@#:+2.12:#@#:
+organisation:#@#:+org.typelevel:#@#:
+branch:#@#:+@#:NULL:#@:#@#:
+revision:#@#:+0.7.0:#@#:
</extraDependencyAttributes>

@adpi2 adpi2 marked this pull request as draft October 7, 2024 13:23
@adpi2 adpi2 marked this pull request as ready for review October 7, 2024 13:41
@adpi2 adpi2 requested a review from eed3si9n October 7, 2024 13:42
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adpi2 adpi2 merged commit ee7e17a into sbt:develop Oct 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eviction for transitive sbt plugin dependencies not working
2 participants